Skip to content

Commit 465880b

Browse files
authored
studied state was not connected (#60)
* studied state was not connected * test for unattached subject state
1 parent 2aed68f commit 465880b

2 files changed

Lines changed: 5 additions & 1 deletion

File tree

bids2openminds/main.py

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -268,7 +268,8 @@ def create_subjects(subject_id, layout_df, layout, collection):
268268
subject_state_dict[f"{subject}"] = state_cache_dict
269269
subject_cache = omcore.Subject(
270270
lookup_label=f"{subject_name}",
271-
internal_identifier=f"{subject_name}"
271+
internal_identifier=f"{subject_name}",
272+
studied_states=state_cache
272273
)
273274
subjects_dict[f"{subject}"] = subject_cache
274275
subjects_list.append(subject_cache)

test/test_bids_examples.py

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -27,10 +27,12 @@ def test_example_datasets(dataset_label, dataset_subject_number, dataset_subject
2727
files_number = 0
2828
file_bundles_number = 0
2929
behavioral_protocol_number = 0
30+
subject_state_number_besed_on_subject = 0
3031

3132
for item in c:
3233
if item.type_ == "https://openminds.ebrains.eu/core/Subject":
3334
subject_number += 1
35+
subject_state_number_besed_on_subject += len(item.studied_states)
3436
if item.type_ == "https://openminds.ebrains.eu/core/SubjectState":
3537
subject_state_number += 1
3638
if item.type_ == "https://openminds.ebrains.eu/core/Person":
@@ -44,6 +46,7 @@ def test_example_datasets(dataset_label, dataset_subject_number, dataset_subject
4446

4547
assert dataset_subject_number == subject_number
4648
assert dataset_subject_state_number == subject_state_number
49+
assert subject_state_number_besed_on_subject == subject_state_number, "There was a discrepancy between the total number of subject states and the subject states attached to subjects."
4750
assert dataset_person_number == person_number
4851
assert dataset_files_number == files_number
4952
assert dataset_file_bundles_number == file_bundles_number

0 commit comments

Comments
 (0)