From bbfcff78113efbc4db03b726a567d41b3ddb25e6 Mon Sep 17 00:00:00 2001 From: Andrew Davison Date: Mon, 2 Sep 2024 15:17:13 +0200 Subject: [PATCH 01/20] Update webhook to only trigger the dev pipeline --- .github/workflows/openMINDS_upstream.yml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.github/workflows/openMINDS_upstream.yml b/.github/workflows/openMINDS_upstream.yml index e08af99..fea76eb 100644 --- a/.github/workflows/openMINDS_upstream.yml +++ b/.github/workflows/openMINDS_upstream.yml @@ -10,4 +10,4 @@ jobs: steps: - name: Trigger central repository run: | - curl -XPOST -u "${{secrets.PAT_USERNAME}}:${{secrets.PAT_TOKEN}}" -H "Accept: application/vnd.github.everest-preview+json" -H "Content-Type: application/json" https://api.github.com/repos/openMetadataInitiative/openMINDS/actions/workflows/build.yml/dispatches --data '{"ref": "pipeline", "inputs": {"branch": "${{github.ref_name}}", "repository": "${{ github.repository }}"}' + curl -XPOST -u "${{secrets.PAT_USERNAME}}:${{secrets.PAT_TOKEN}}" -H "Accept: application/vnd.github.everest-preview+json" -H "Content-Type: application/json" https://api.github.com/repos/openMetadataInitiative/openMINDS/actions/workflows/build-dev.yml/dispatches --data '{"ref": "pipeline", "inputs": {"branch": "${{github.ref_name}}", "repository": "${{ github.repository }}"}' From c58facdb4a051498a9b309da6f0c161590314091 Mon Sep 17 00:00:00 2001 From: Andrew Davison Date: Mon, 31 Mar 2025 16:44:44 +0200 Subject: [PATCH 02/20] Fix JSON sent by curl in openMINDS_upstream.yml --- .github/workflows/openMINDS_upstream.yml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.github/workflows/openMINDS_upstream.yml b/.github/workflows/openMINDS_upstream.yml index fea76eb..5061430 100644 --- a/.github/workflows/openMINDS_upstream.yml +++ b/.github/workflows/openMINDS_upstream.yml @@ -10,4 +10,4 @@ jobs: steps: - name: Trigger central repository run: | - curl -XPOST -u "${{secrets.PAT_USERNAME}}:${{secrets.PAT_TOKEN}}" -H "Accept: application/vnd.github.everest-preview+json" -H "Content-Type: application/json" https://api.github.com/repos/openMetadataInitiative/openMINDS/actions/workflows/build-dev.yml/dispatches --data '{"ref": "pipeline", "inputs": {"branch": "${{github.ref_name}}", "repository": "${{ github.repository }}"}' + curl -XPOST -u "${{secrets.PAT_USERNAME}}:${{secrets.PAT_TOKEN}}" -H "Accept: application/vnd.github.everest-preview+json" -H "Content-Type: application/json" https://api.github.com/repos/openMetadataInitiative/openMINDS/actions/workflows/build-dev.yml/dispatches --data '{"ref": "pipeline", "inputs": {"branch": "${{github.ref_name}}", "repository": "${{ github.repository }}"}}' From c9e2508279512c7893f852b5ae267aba3e72cb3d Mon Sep 17 00:00:00 2001 From: abonard Date: Fri, 23 Jan 2026 15:29:07 +0100 Subject: [PATCH 03/20] Add required (acquisitionDuration, behavioralProtocol) in functionalMRIAcquisition --- schemas/activity/functionalMRIAcquisition.schema.tpl.json | 4 ++++ 1 file changed, 4 insertions(+) diff --git a/schemas/activity/functionalMRIAcquisition.schema.tpl.json b/schemas/activity/functionalMRIAcquisition.schema.tpl.json index 27b68b7..b8c5d64 100644 --- a/schemas/activity/functionalMRIAcquisition.schema.tpl.json +++ b/schemas/activity/functionalMRIAcquisition.schema.tpl.json @@ -1,6 +1,10 @@ { "_extends": "activity/MRIAcquisition.schema.tpl.json", "_type": "neuroimaging:FunctionalMRIAcquisition", + "required": [ + "acquisitionDuration", + "behavioralProtocol" + ], "properties": { "acquisitionDuration": { "_embeddedTypes": [ From 3e7c99c49f896368c624e23d09a57242e515b8cb Mon Sep 17 00:00:00 2001 From: abonard Date: Mon, 9 Feb 2026 11:18:42 +0100 Subject: [PATCH 04/20] Change name property structuralMRI by registration data in fucntionalMRIAcquisition schema --- schemas/activity/functionalMRIAcquisition.schema.tpl.json | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/schemas/activity/functionalMRIAcquisition.schema.tpl.json b/schemas/activity/functionalMRIAcquisition.schema.tpl.json index b8c5d64..56aa2d7 100644 --- a/schemas/activity/functionalMRIAcquisition.schema.tpl.json +++ b/schemas/activity/functionalMRIAcquisition.schema.tpl.json @@ -51,8 +51,8 @@ "core:File" ] }, - "structuralMRI": { - "_instruction": "Add the structural MRI relevant for this acquisition.", + "registration data": { + "_instruction": "Add the registration file corresponding to structural MRI relevant for this acquisition.", "_linkedTypes": [ "core:File" ] From 742ce4a2fa90ff85b9d891f39d9f4d5ceb57ff3c Mon Sep 17 00:00:00 2001 From: abonard Date: Mon, 9 Feb 2026 11:19:27 +0100 Subject: [PATCH 05/20] Remove delayAfterTrigger property in functionalMRIAcquisition schema --- schemas/activity/functionalMRIAcquisition.schema.tpl.json | 6 ------ 1 file changed, 6 deletions(-) diff --git a/schemas/activity/functionalMRIAcquisition.schema.tpl.json b/schemas/activity/functionalMRIAcquisition.schema.tpl.json index 56aa2d7..0cd46ce 100644 --- a/schemas/activity/functionalMRIAcquisition.schema.tpl.json +++ b/schemas/activity/functionalMRIAcquisition.schema.tpl.json @@ -21,12 +21,6 @@ "type": "array", "uniqueItems": true }, - "delayAfterTrigger": { - "_embeddedTypes": [ - "core:QuantitativeValue" - ], - "_instruction": "Enter the duration from trigger delivery to scan onset (only the first volume)." - }, "delayTime": { "_embeddedTypes": [ "core:QuantitativeValue" From 17984c7e4382eaa81c21c055d927e27b34010adf Mon Sep 17 00:00:00 2001 From: abonard Date: Mon, 9 Feb 2026 11:21:34 +0100 Subject: [PATCH 06/20] Change name property sbref by motion correction with all updates needed in functionalMRIAcquisition schema --- .../functionalMRIAcquisition.schema.tpl.json | 12 ++++++------ 1 file changed, 6 insertions(+), 6 deletions(-) diff --git a/schemas/activity/functionalMRIAcquisition.schema.tpl.json b/schemas/activity/functionalMRIAcquisition.schema.tpl.json index 0cd46ce..fbf5e44 100644 --- a/schemas/activity/functionalMRIAcquisition.schema.tpl.json +++ b/schemas/activity/functionalMRIAcquisition.schema.tpl.json @@ -35,16 +35,16 @@ "minItems": 1, "type": "array" }, - "numberOfVolumesDiscardedByUser": { - "_instruction": "Enter number of volumes discarded by user before the first volume.", - "type": "number" - }, - "sbref": { - "_instruction": "Add the single-band reference image for this volume.", + "motion correction": { + "_instruction": "Add the calibration file used for motion correction, corresponding to single-band reference image, for this volume.", "_linkedTypes": [ "core:File" ] }, + "numberOfVolumesDiscardedByUser": { + "_instruction": "Enter number of volumes discarded by user before the first volume.", + "type": "number" + }, "registration data": { "_instruction": "Add the registration file corresponding to structural MRI relevant for this acquisition.", "_linkedTypes": [ From c696acebd1064dfbcf4765cef461aad2bd241cd8 Mon Sep 17 00:00:00 2001 From: abonard Date: Mon, 9 Feb 2026 11:26:08 +0100 Subject: [PATCH 07/20] Change name property fieldMap by distorsion correction with all updates needed in functionalMRIAcquisition schema --- schemas/activity/functionalMRIAcquisition.schema.tpl.json | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/schemas/activity/functionalMRIAcquisition.schema.tpl.json b/schemas/activity/functionalMRIAcquisition.schema.tpl.json index fbf5e44..96059ba 100644 --- a/schemas/activity/functionalMRIAcquisition.schema.tpl.json +++ b/schemas/activity/functionalMRIAcquisition.schema.tpl.json @@ -27,8 +27,8 @@ ], "_instruction": "Enter the arbitrary delay time set by user before each volume acquisition." }, - "fieldMap": { - "_instruction": "Add the images or field maps used for correction of inhomogeneities in B0 field of this acquisition.", + "distorsion correction": { + "_instruction": "Add the calibration file corresponding to images or field maps used for correction of inhomogeneities in B0 field of this acquisition.", "_linkedTypes": [ "core:File" ], From e3458ec3ed5d29906bf38d84c4dedf985dffbb6d Mon Sep 17 00:00:00 2001 From: abonard Date: Thu, 12 Feb 2026 17:14:51 +0100 Subject: [PATCH 08/20] Fix required field spacing --- schemas/activity/functionalMRIAcquisition.schema.tpl.json | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/schemas/activity/functionalMRIAcquisition.schema.tpl.json b/schemas/activity/functionalMRIAcquisition.schema.tpl.json index 96059ba..0da573e 100644 --- a/schemas/activity/functionalMRIAcquisition.schema.tpl.json +++ b/schemas/activity/functionalMRIAcquisition.schema.tpl.json @@ -1,7 +1,7 @@ { "_extends": "activity/MRIAcquisition.schema.tpl.json", "_type": "neuroimaging:FunctionalMRIAcquisition", - "required": [ + "required": [ "acquisitionDuration", "behavioralProtocol" ], From fabdbbae39f4d5604676d0865d1e86d530d679ca Mon Sep 17 00:00:00 2001 From: abonard Date: Thu, 12 Feb 2026 17:26:41 +0100 Subject: [PATCH 09/20] fix typo distortion --- schemas/activity/functionalMRIAcquisition.schema.tpl.json | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/schemas/activity/functionalMRIAcquisition.schema.tpl.json b/schemas/activity/functionalMRIAcquisition.schema.tpl.json index 0da573e..bed840d 100644 --- a/schemas/activity/functionalMRIAcquisition.schema.tpl.json +++ b/schemas/activity/functionalMRIAcquisition.schema.tpl.json @@ -27,7 +27,7 @@ ], "_instruction": "Enter the arbitrary delay time set by user before each volume acquisition." }, - "distorsion correction": { + "distortion correction": { "_instruction": "Add the calibration file corresponding to images or field maps used for correction of inhomogeneities in B0 field of this acquisition.", "_linkedTypes": [ "core:File" From eeda0a3a91b21b524d476764c9b3b7a7a55b7e1d Mon Sep 17 00:00:00 2001 From: abonard Date: Tue, 17 Feb 2026 12:16:51 +0100 Subject: [PATCH 10/20] Move distortionCorrection, motionCorrection, registrationData to MRIAcquisition --- .../functionalMRIAcquisition.schema.tpl.json | 20 ------------------- 1 file changed, 20 deletions(-) diff --git a/schemas/activity/functionalMRIAcquisition.schema.tpl.json b/schemas/activity/functionalMRIAcquisition.schema.tpl.json index bed840d..2c25276 100644 --- a/schemas/activity/functionalMRIAcquisition.schema.tpl.json +++ b/schemas/activity/functionalMRIAcquisition.schema.tpl.json @@ -27,30 +27,10 @@ ], "_instruction": "Enter the arbitrary delay time set by user before each volume acquisition." }, - "distortion correction": { - "_instruction": "Add the calibration file corresponding to images or field maps used for correction of inhomogeneities in B0 field of this acquisition.", - "_linkedTypes": [ - "core:File" - ], - "minItems": 1, - "type": "array" - }, - "motion correction": { - "_instruction": "Add the calibration file used for motion correction, corresponding to single-band reference image, for this volume.", - "_linkedTypes": [ - "core:File" - ] - }, "numberOfVolumesDiscardedByUser": { "_instruction": "Enter number of volumes discarded by user before the first volume.", "type": "number" }, - "registration data": { - "_instruction": "Add the registration file corresponding to structural MRI relevant for this acquisition.", - "_linkedTypes": [ - "core:File" - ] - }, "volumeTiming": { "_instruction": "Enter acquisition times of each vloume.", "_linkedTypes": [ From ab6800646736bfd3629b65bb5b56ec95a3be95c7 Mon Sep 17 00:00:00 2001 From: abonard Date: Wed, 18 Feb 2026 00:28:47 +0100 Subject: [PATCH 11/20] Rename functionalMRIAcquisition by dynamicMRIAcquisition --- .../functionalMRIAcquisition.schema.tpl.json | 41 ------------------- 1 file changed, 41 deletions(-) delete mode 100644 schemas/activity/functionalMRIAcquisition.schema.tpl.json diff --git a/schemas/activity/functionalMRIAcquisition.schema.tpl.json b/schemas/activity/functionalMRIAcquisition.schema.tpl.json deleted file mode 100644 index 2c25276..0000000 --- a/schemas/activity/functionalMRIAcquisition.schema.tpl.json +++ /dev/null @@ -1,41 +0,0 @@ -{ - "_extends": "activity/MRIAcquisition.schema.tpl.json", - "_type": "neuroimaging:FunctionalMRIAcquisition", - "required": [ - "acquisitionDuration", - "behavioralProtocol" - ], - "properties": { - "acquisitionDuration": { - "_embeddedTypes": [ - "core:QuantitativeValue" - ], - "_instruction": "Enter duration of volume acquisition." - }, - "behavioralProtocol": { - "_instruction": "Add all behavioral protocols that were performed during this session.", - "_linkedTypes": [ - "core:BehavioralProtocol" - ], - "minItems": 1, - "type": "array", - "uniqueItems": true - }, - "delayTime": { - "_embeddedTypes": [ - "core:QuantitativeValue" - ], - "_instruction": "Enter the arbitrary delay time set by user before each volume acquisition." - }, - "numberOfVolumesDiscardedByUser": { - "_instruction": "Enter number of volumes discarded by user before the first volume.", - "type": "number" - }, - "volumeTiming": { - "_instruction": "Enter acquisition times of each vloume.", - "_linkedTypes": [ - "core:QuantitativeValueArray" - ] - } - } -} From 30d890bdbad58d6ca2d36eedf5b2e4e273a5ec2c Mon Sep 17 00:00:00 2001 From: abonard Date: Wed, 18 Feb 2026 00:29:47 +0100 Subject: [PATCH 12/20] Add dynamicMRIAcquisition schema with volumeAcquisitionTime instead of acquisitionDuration --- .../dynamicMRIAcquisition.schema.tpl.json | 41 +++++++++++++++++++ 1 file changed, 41 insertions(+) create mode 100644 schemas/activity/dynamicMRIAcquisition.schema.tpl.json diff --git a/schemas/activity/dynamicMRIAcquisition.schema.tpl.json b/schemas/activity/dynamicMRIAcquisition.schema.tpl.json new file mode 100644 index 0000000..2285f77 --- /dev/null +++ b/schemas/activity/dynamicMRIAcquisition.schema.tpl.json @@ -0,0 +1,41 @@ +{ + "_extends": "activity/MRIAcquisition.schema.tpl.json", + "_type": "neuroimaging:DynamicMRIAcquisition", + "required": [ + "behavioralProtocol", + "volumeAcquisitionTime" + ], + "properties": { + "behavioralProtocol": { + "_instruction": "Add all behavioral protocols that were performed during this session.", + "_linkedTypes": [ + "core:BehavioralProtocol" + ], + "minItems": 1, + "type": "array", + "uniqueItems": true + }, + "delayTime": { + "_embeddedTypes": [ + "core:QuantitativeValue" + ], + "_instruction": "Enter the arbitrary delay time set by user before each volume acquisition." + }, + "numberOfVolumesDiscardedByUser": { + "_instruction": "Enter number of volumes discarded by user before the first volume.", + "type": "number" + }, + "volumeAcquisitionTime": { + "_embeddedTypes": [ + "core:QuantitativeValue" + ], + "_instruction": "Enter duration of volume acquisition." + }, + "volumeTiming": { + "_instruction": "Enter acquisition times of each vloume.", + "_linkedTypes": [ + "core:QuantitativeValueArray" + ] + } + } +} From 2090e589d3c11cb078456d7374905da715e0109d Mon Sep 17 00:00:00 2001 From: Alix Bonard <117838894+Alixbonard@users.noreply.github.com> Date: Fri, 20 Feb 2026 16:14:15 +0100 Subject: [PATCH 13/20] Apply suggestion from @lzehl Co-authored-by: Lyuba Zehl --- schemas/activity/dynamicMRIAcquisition.schema.tpl.json | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/schemas/activity/dynamicMRIAcquisition.schema.tpl.json b/schemas/activity/dynamicMRIAcquisition.schema.tpl.json index 2285f77..43c1467 100644 --- a/schemas/activity/dynamicMRIAcquisition.schema.tpl.json +++ b/schemas/activity/dynamicMRIAcquisition.schema.tpl.json @@ -7,7 +7,7 @@ ], "properties": { "behavioralProtocol": { - "_instruction": "Add all behavioral protocols that were performed during this session.", + "_instruction": "Add the behavioral protocol or protocols applied during this acquisition, including all tasks or observed behavioral conditions (for example, resting state).", "_linkedTypes": [ "core:BehavioralProtocol" ], From 533080f1091b13ae7ec44f3dc8eb40b0a228e228 Mon Sep 17 00:00:00 2001 From: Alix Bonard <117838894+Alixbonard@users.noreply.github.com> Date: Fri, 20 Feb 2026 16:14:24 +0100 Subject: [PATCH 14/20] Apply suggestion from @lzehl Co-authored-by: Lyuba Zehl --- schemas/activity/dynamicMRIAcquisition.schema.tpl.json | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/schemas/activity/dynamicMRIAcquisition.schema.tpl.json b/schemas/activity/dynamicMRIAcquisition.schema.tpl.json index 43c1467..132772a 100644 --- a/schemas/activity/dynamicMRIAcquisition.schema.tpl.json +++ b/schemas/activity/dynamicMRIAcquisition.schema.tpl.json @@ -32,7 +32,7 @@ "_instruction": "Enter duration of volume acquisition." }, "volumeTiming": { - "_instruction": "Enter acquisition times of each vloume.", + "_instruction": "Enter the volume timing as an array specifying the acquisition time of each volume relative to the start of the dynamic scan, expressed in seconds, with one entry per acquired volume. These values may be derived from the repetition time or extracted from the acquisition metadata.", "_linkedTypes": [ "core:QuantitativeValueArray" ] From 67af4e28e925d30d7462fcd2da5ea56858b80f09 Mon Sep 17 00:00:00 2001 From: Alix Bonard <117838894+Alixbonard@users.noreply.github.com> Date: Fri, 20 Feb 2026 16:14:31 +0100 Subject: [PATCH 15/20] Apply suggestion from @lzehl Co-authored-by: Lyuba Zehl --- schemas/activity/dynamicMRIAcquisition.schema.tpl.json | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/schemas/activity/dynamicMRIAcquisition.schema.tpl.json b/schemas/activity/dynamicMRIAcquisition.schema.tpl.json index 132772a..2b0f222 100644 --- a/schemas/activity/dynamicMRIAcquisition.schema.tpl.json +++ b/schemas/activity/dynamicMRIAcquisition.schema.tpl.json @@ -19,7 +19,7 @@ "_embeddedTypes": [ "core:QuantitativeValue" ], - "_instruction": "Enter the arbitrary delay time set by user before each volume acquisition." + "_instruction": "Enter the delay time, defined as the time interval between a protocol-defined reference event (for example, stimulus onset, contrast administration, or physiological trigger) and the start of dynamic image acquisition, expressed in seconds. This value should reflect the actual timing applied during the scan." }, "numberOfVolumesDiscardedByUser": { "_instruction": "Enter number of volumes discarded by user before the first volume.", From 00966cf6029f9359af24f10c50732ec1f798805e Mon Sep 17 00:00:00 2001 From: Alix Bonard <117838894+Alixbonard@users.noreply.github.com> Date: Fri, 20 Feb 2026 16:15:06 +0100 Subject: [PATCH 16/20] Apply suggestion from @lzehl Co-authored-by: Lyuba Zehl --- schemas/activity/dynamicMRIAcquisition.schema.tpl.json | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/schemas/activity/dynamicMRIAcquisition.schema.tpl.json b/schemas/activity/dynamicMRIAcquisition.schema.tpl.json index 2b0f222..eccda6c 100644 --- a/schemas/activity/dynamicMRIAcquisition.schema.tpl.json +++ b/schemas/activity/dynamicMRIAcquisition.schema.tpl.json @@ -21,10 +21,10 @@ ], "_instruction": "Enter the delay time, defined as the time interval between a protocol-defined reference event (for example, stimulus onset, contrast administration, or physiological trigger) and the start of dynamic image acquisition, expressed in seconds. This value should reflect the actual timing applied during the scan." }, - "numberOfVolumesDiscardedByUser": { - "_instruction": "Enter number of volumes discarded by user before the first volume.", - "type": "number" - }, +"numberOfDiscardedVolumes": { +"_instruction": "Enter the number of image volumes discarded by the operator or analyst prior to post-processing, including initial equilibration volumes and any later volumes removed due to artifacts or instability. This value should reflect the total user-defined exclusion applied after acquisition.", +"type": "integer" +}, "volumeAcquisitionTime": { "_embeddedTypes": [ "core:QuantitativeValue" From ca6d9d9d9416ca30334917c3e4e9359ab3d74d0e Mon Sep 17 00:00:00 2001 From: Alix Bonard <117838894+Alixbonard@users.noreply.github.com> Date: Fri, 20 Feb 2026 16:15:14 +0100 Subject: [PATCH 17/20] Apply suggestion from @lzehl Co-authored-by: Lyuba Zehl --- schemas/activity/dynamicMRIAcquisition.schema.tpl.json | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/schemas/activity/dynamicMRIAcquisition.schema.tpl.json b/schemas/activity/dynamicMRIAcquisition.schema.tpl.json index eccda6c..65bac2f 100644 --- a/schemas/activity/dynamicMRIAcquisition.schema.tpl.json +++ b/schemas/activity/dynamicMRIAcquisition.schema.tpl.json @@ -29,7 +29,7 @@ "_embeddedTypes": [ "core:QuantitativeValue" ], - "_instruction": "Enter duration of volume acquisition." + "_instruction": "Enter the volume acquisition time, defined as the time required to acquire a single image volume, expressed in seconds. This value is typically equivalent to the repetition time for volume-based acquisitions and can be retrieved from the sequence timing information in the DICOM header." }, "volumeTiming": { "_instruction": "Enter the volume timing as an array specifying the acquisition time of each volume relative to the start of the dynamic scan, expressed in seconds, with one entry per acquired volume. These values may be derived from the repetition time or extracted from the acquisition metadata.", From 12d965cebefc8d778f02b28365f56ee2e54eb529 Mon Sep 17 00:00:00 2001 From: abonard Date: Fri, 20 Feb 2026 17:00:40 +0100 Subject: [PATCH 18/20] Fix indentations, instructions location and typo in volumeTiming --- .../dynamicMRIAcquisition.schema.tpl.json | 18 +++++++++--------- 1 file changed, 9 insertions(+), 9 deletions(-) diff --git a/schemas/activity/dynamicMRIAcquisition.schema.tpl.json b/schemas/activity/dynamicMRIAcquisition.schema.tpl.json index 65bac2f..7f97792 100644 --- a/schemas/activity/dynamicMRIAcquisition.schema.tpl.json +++ b/schemas/activity/dynamicMRIAcquisition.schema.tpl.json @@ -16,23 +16,23 @@ "uniqueItems": true }, "delayTime": { + "_instruction": "Enter the delay time, defined as the time interval between a protocol-defined reference event (for example, stimulus onset, contrast administration, or physiological trigger) and the start of dynamic image acquisition, expressed in seconds. This value should reflect the actual timing applied during the scan.", "_embeddedTypes": [ "core:QuantitativeValue" - ], - "_instruction": "Enter the delay time, defined as the time interval between a protocol-defined reference event (for example, stimulus onset, contrast administration, or physiological trigger) and the start of dynamic image acquisition, expressed in seconds. This value should reflect the actual timing applied during the scan." + ] + }, + "numberOfDiscardedVolumes": { + "_instruction": "Enter the number of image volumes discarded by the operator or analyst prior to post-processing, including initial equilibration volumes and any later volumes removed due to artifacts or instability. This value should reflect the total user-defined exclusion applied after acquisition.", + "type": "integer" }, -"numberOfDiscardedVolumes": { -"_instruction": "Enter the number of image volumes discarded by the operator or analyst prior to post-processing, including initial equilibration volumes and any later volumes removed due to artifacts or instability. This value should reflect the total user-defined exclusion applied after acquisition.", -"type": "integer" -}, "volumeAcquisitionTime": { + "_instruction": "Enter the volume acquisition time, defined as the time required to acquire a single image volume, expressed in seconds. This value is typically equivalent to the repetition time for volume-based acquisitions and can be retrieved from the sequence timing information in the DICOM header.", "_embeddedTypes": [ "core:QuantitativeValue" - ], - "_instruction": "Enter the volume acquisition time, defined as the time required to acquire a single image volume, expressed in seconds. This value is typically equivalent to the repetition time for volume-based acquisitions and can be retrieved from the sequence timing information in the DICOM header." + ] }, "volumeTiming": { - "_instruction": "Enter the volume timing as an array specifying the acquisition time of each volume relative to the start of the dynamic scan, expressed in seconds, with one entry per acquired volume. These values may be derived from the repetition time or extracted from the acquisition metadata.", + "_instruction": "Add the volume timing as an array specifying the acquisition time of each volume relative to the start of the dynamic scan, expressed in seconds, with one entry per acquired volume. These values may be derived from the repetition time or extracted from the acquisition metadata.", "_linkedTypes": [ "core:QuantitativeValueArray" ] From 09070515cf30f3f9488970e252b277796b8e0677 Mon Sep 17 00:00:00 2001 From: abonard Date: Fri, 20 Feb 2026 17:11:09 +0100 Subject: [PATCH 19/20] Fix _extends field --- schemas/activity/dynamicMRIAcquisition.schema.tpl.json | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/schemas/activity/dynamicMRIAcquisition.schema.tpl.json b/schemas/activity/dynamicMRIAcquisition.schema.tpl.json index 7f97792..6794fcd 100644 --- a/schemas/activity/dynamicMRIAcquisition.schema.tpl.json +++ b/schemas/activity/dynamicMRIAcquisition.schema.tpl.json @@ -1,5 +1,5 @@ { - "_extends": "activity/MRIAcquisition.schema.tpl.json", + "_extends": "activity/staticMRIAcquisition.schema.tpl.json", "_type": "neuroimaging:DynamicMRIAcquisition", "required": [ "behavioralProtocol", From 23e7f15cde317f6969ceb6e56290ce13cedb745c Mon Sep 17 00:00:00 2001 From: abonard Date: Fri, 20 Feb 2026 17:42:05 +0100 Subject: [PATCH 20/20] Update extends field with MRIAcquisition --- schemas/activity/dynamicMRIAcquisition.schema.tpl.json | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/schemas/activity/dynamicMRIAcquisition.schema.tpl.json b/schemas/activity/dynamicMRIAcquisition.schema.tpl.json index 6794fcd..7f97792 100644 --- a/schemas/activity/dynamicMRIAcquisition.schema.tpl.json +++ b/schemas/activity/dynamicMRIAcquisition.schema.tpl.json @@ -1,5 +1,5 @@ { - "_extends": "activity/staticMRIAcquisition.schema.tpl.json", + "_extends": "activity/MRIAcquisition.schema.tpl.json", "_type": "neuroimaging:DynamicMRIAcquisition", "required": [ "behavioralProtocol",