Add series.iterations to test

Author: franzpoeschel

src/Series.cpp

@@ -2360,7 +2360,17 @@ creating new iterations.
         readableIterations.reserve(pList.paths->size());
         for (auto const &it : *pList.paths)
         {
-            IterationIndex_t index = std::stoull(it);
+            IterationIndex_t index;
+            try
+            {
+                index = std::stoull(it);
+            }
+            catch (std::exception const &e)
+            {
+                std::cerr << "[Warning] Could not parse '" << it
+                          << "' as an Iteration index. Will skip." << std::endl;
+                continue;
+            }
             if (read_only_this_single_iteration.has_value() &&
                 index != *read_only_this_single_iteration)
             {

src/backend/Attributable.cpp

@@ -198,11 +198,6 @@ void Attributable::customHierarchyFlush(
     // customHierarchies().printRecursively();
     if (!dirtyRecursive())
     {
-        if (!unset_dirty)
-        {
-            throw std::runtime_error(
-                "Control flow error: Should be called upon a dirty object.");
-        }
         return;
     }
 

test/Files_Core/custom_hierarchy.cpp

@@ -41,12 +41,13 @@ void write(
     IterationEncoding)
 {
     Series series(filename, Access::CREATE_LINEAR, json_params);
-    auto add_custom_hierarchy = [](Attributable &attr) {
+    auto add_custom_hierarchy = [](auto &&attr) {
         attr.customHierarchies()["rabimmel"].setAttribute("rabammel", "rabumm");
     };
     auto iteration = series.snapshots()[0];
 
     add_custom_hierarchy(series);
+    add_custom_hierarchy(series.snapshots());
     add_custom_hierarchy(iteration);
     iteration.close();
 }
@@ -57,8 +58,8 @@ void read(
     IterationEncoding)
 {
     Series series(filename, Access::READ_LINEAR, json_params);
-    auto require_custom_hierarchy = [](Attributable &attr) {
-        auto ch = attr.customHierarchies();
+    auto require_custom_hierarchy = [](auto &&attr) {
+        CustomHierarchy ch = attr.customHierarchies();
         REQUIRE(ch.find("rabimmel") == ch.end());
         ch.read(0);
         REQUIRE(
@@ -68,6 +69,7 @@ void read(
     auto iteration = series.snapshots()[0];
 
     require_custom_hierarchy(series);
+    require_custom_hierarchy(series.snapshots());
     require_custom_hierarchy(iteration);
     iteration.close();
 }