Fix use after free in ADIOS1IOHandler

Author: franzpoeschel

include/openPMD/IO/ADIOS/CommonADIOS1IOHandler.hpp

@@ -88,7 +88,12 @@ namespace openPMD
         std::unordered_map< std::shared_ptr< std::string >, bool > m_existsOnDisk;
         std::unordered_map< std::shared_ptr< std::string >, int64_t > m_openWriteFileHandles;
         std::unordered_map< std::shared_ptr< std::string >, ADIOS_FILE* > m_openReadFileHandles;
-        std::unordered_map< ADIOS_FILE*, std::vector< ADIOS_SELECTION* > > m_scheduledReads;
+        struct ScheduledRead
+        {
+            ADIOS_SELECTION* selection;
+            std::shared_ptr< void > data; // needed to avoid early freeing
+        };
+        std::unordered_map< ADIOS_FILE*, std::vector< ScheduledRead > > m_scheduledReads;
         std::unordered_map< int64_t, std::unordered_map< std::string, Attribute > > m_attributeWrites;
         // config options
         std::string m_defaultTransform;

src/IO/ADIOS/ADIOS1IOHandler.cpp

@@ -212,7 +212,7 @@ ADIOS1IOHandlerImpl::flush()
         VERIFY(status == err_no_error, "[ADIOS1] Internal error: Failed to perform ADIOS reads during dataset reading");
 
         for( auto& sel : file.second )
-            adios_selection_delete(sel);
+            adios_selection_delete(sel.selection);
     }
     m_scheduledReads.clear();
 

src/IO/ADIOS/CommonADIOS1IOHandler.cpp

@@ -701,7 +701,7 @@ CommonADIOS1IOHandlerImpl< ChildClass >::closeFile(
                 "dataset reading" );
 
             for( auto & sel : scheduled->second )
-                adios_selection_delete( sel );
+                adios_selection_delete( sel.selection );
             m_scheduledReads.erase( scheduled );
         }
         close( handle_read->second );
@@ -1129,7 +1129,7 @@ CommonADIOS1IOHandlerImpl< ChildClass >::readDataset(Writable* writable,
     VERIFY(status == err_no_error, "[ADIOS1] Internal error: Failed to schedule ADIOS read during dataset reading");
     VERIFY(adios_errno == err_no_error, "[ADIOS1] Internal error: Failed to schedule ADIOS read during dataset reading");
 
-    m_scheduledReads[f].push_back(sel);
+    m_scheduledReads[f].push_back({sel, parameters.data});
 }
 
 template< typename ChildClass >

src/IO/ADIOS/ParallelADIOS1IOHandler.cpp

@@ -232,7 +232,7 @@ ParallelADIOS1IOHandlerImpl::flush()
         VERIFY(status == err_no_error, "[ADIOS1] Internal error: Failed to perform ADIOS reads during dataset reading");
 
         for( auto& sel : file.second )
-            adios_selection_delete(sel);
+            adios_selection_delete(sel.selection);
     }
     m_scheduledReads.clear();