Move dirtyRecursive to CustomHierarchy

Author: franzpoeschel

include/openPMD/CustomHierarchy.hpp

@@ -102,6 +102,16 @@ class CustomHierarchy : public Container<CustomHierarchy>
 
     void linkHierarchy(Writable &w) override;
 
+    /*
+     * @brief Check recursively whether this object is dirty.
+     *        It is dirty if any attribute or dataset is read from or written to
+     *        the backend.
+     *
+     * @return true If dirty.
+     * @return false Otherwise.
+     */
+    bool dirtyRecursive() const;
+
 public:
     CustomHierarchy(CustomHierarchy const &other) = default;
     CustomHierarchy(CustomHierarchy &&other) = default;

include/openPMD/Iteration.hpp

@@ -388,16 +388,6 @@ class Iteration : public CustomHierarchy
      */
     void setStepStatus(StepStatus);
 
-    /*
-     * @brief Check recursively whether this Iteration is dirty.
-     *        It is dirty if any attribute or dataset is read from or written to
-     *        the backend.
-     *
-     * @return true If dirty.
-     * @return false Otherwise.
-     */
-    bool dirtyRecursive() const;
-
     /**
      * @brief Access an iteration in read mode that has potentially not been
      *      parsed yet.

src/CustomHierarchy.cpp

@@ -397,6 +397,47 @@ void CustomHierarchy::linkHierarchy(Writable &w)
     particles.linkHierarchy(this->writable());
 }
 
+bool CustomHierarchy::dirtyRecursive() const
+{
+    if (dirty())
+    {
+        return true;
+    }
+    if (particles.dirty() || meshes.dirty())
+    {
+        return true;
+    }
+    for (auto const &pair : particles)
+    {
+        if (pair.second.dirtyRecursive())
+        {
+            return true;
+        }
+    }
+    for (auto const &pair : meshes)
+    {
+        if (pair.second.dirtyRecursive())
+        {
+            return true;
+        }
+    }
+    for (auto const &pair : *this)
+    {
+        if (pair.second.dirtyRecursive())
+        {
+            return true;
+        }
+    }
+    for (auto const &pair : get().m_embeddedDatasets)
+    {
+        if (pair.second.dirtyRecursive())
+        {
+            return true;
+        }
+    }
+    return false;
+}
+
 Container<RecordComponent> CustomHierarchy::datasets()
 {
     Container<RecordComponent> res = get().m_embeddedDatasets;

src/Iteration.cpp

@@ -619,33 +619,6 @@ void Iteration::setStepStatus(StepStatus status)
     }
 }
 
-bool Iteration::dirtyRecursive() const
-{
-    if (dirty())
-    {
-        return true;
-    }
-    if (particles.dirty() || meshes.dirty())
-    {
-        return true;
-    }
-    for (auto const &pair : particles)
-    {
-        if (pair.second.dirtyRecursive())
-        {
-            return true;
-        }
-    }
-    for (auto const &pair : meshes)
-    {
-        if (pair.second.dirtyRecursive())
-        {
-            return true;
-        }
-    }
-    return false;
-}
-
 void Iteration::runDeferredParseAccess()
 {
     if (access::read(IOHandler()->m_frontendAccess))