Fix dirty handling

Author: franzpoeschel

include/openPMD/backend/Attributable.hpp

@@ -553,6 +553,28 @@ OPENPMD_protected
     {
         return writable().dirtyRecursive;
     }
+    void determineUnsetDirty(FlushLevel fl)
+    {
+        switch (fl)
+        {
+        case FlushLevel::UserFlush:
+            setDirty(false);
+            break;
+        case FlushLevel::InternalFlush:
+            // Used for parsing
+            if (IOHandler()->m_seriesStatus == internal::SeriesStatus::Parsing)
+            {
+                throw error::Internal(
+                    "Parsing procedures should directly unset dirty.");
+            }
+            break;
+        case FlushLevel::ImmediateFlush:
+        case FlushLevel::SkeletonOnly:
+        case FlushLevel::CreateOrOpenFiles:
+            // noop
+            break;
+        }
+    }
     void setDirty(bool dirty_in)
     {
         auto &w = writable();

src/Iteration.cpp

@@ -393,7 +393,7 @@ void Iteration::flush(internal::FlushParams const &flushParams)
             m.second.flush(m.first, flushParams);
         for (auto &species : particles)
             species.second.flush(species.first, flushParams);
-        setDirty(false);
+        determineUnsetDirty(flushParams.flushLevel);
     }
     else
     {
@@ -447,9 +447,9 @@ void Iteration::flush(internal::FlushParams const &flushParams)
     }
     if (flushParams.flushLevel != FlushLevel::SkeletonOnly)
     {
-        setDirty(false);
-        meshes.setDirty(false);
-        particles.setDirty(false);
+        determineUnsetDirty(flushParams.flushLevel);
+        meshes.determineUnsetDirty(flushParams.flushLevel);
+        particles.determineUnsetDirty(flushParams.flushLevel);
     }
 }
 

src/ParticleSpecies.cpp

@@ -188,11 +188,8 @@ void ParticleSpecies::flush(
                 patch.second.flush(patch.first, flushParams);
         }
     }
-    if (flushParams.flushLevel != FlushLevel::SkeletonOnly)
-    {
-        particlePatches.setDirty(false);
-        setDirty(false);
-    }
+    determineUnsetDirty(flushParams.flushLevel);
+    particlePatches.determineUnsetDirty(flushParams.flushLevel);
 }
 void ParticleSpecies::scientificDefaults_impl(bool /* write */, OpenpmdStandard)
 {

src/RecordComponent.cpp

@@ -611,10 +611,7 @@ void RecordComponent::flush(
 
         flushAttributes(flushParams);
     }
-    if (flushParams.flushLevel != FlushLevel::SkeletonOnly)
-    {
-        setDirty(false);
-    }
+    determineUnsetDirty(flushParams.flushLevel);
 }
 
 void RecordComponent::read()

src/backend/Attributable.cpp

@@ -328,10 +328,7 @@ void Attributable::flushAttributes(internal::FlushParams const &flushParams)
         }
     }
     // Do this outside the if branch to also setDirty to dirtyRecursive
-    if (flushParams.flushLevel != FlushLevel::SkeletonOnly)
-    {
-        setDirty(false);
-    }
+    determineUnsetDirty(flushParams.flushLevel);
 }
 
 void Attributable::readAttributes(ReadMode mode)

src/backend/BaseRecord.cpp

@@ -793,10 +793,7 @@ inline void BaseRecord<T_elem>::flush(
     }
 
     this->flush_impl(name, flushParams);
-    if (flushParams.flushLevel != FlushLevel::SkeletonOnly)
-    {
-        this->setDirty(false);
-    }
+    this->determineUnsetDirty(flushParams.flushLevel);
     // flush_impl must take care to correctly set the dirty() flag so this
     // method doesn't do it
 }

src/backend/PatchRecord.cpp

@@ -65,10 +65,7 @@ void PatchRecord::flush_impl(
     }
     else
         T_RecordComponent::flush(path, flushParams);
-    if (flushParams.flushLevel != FlushLevel::SkeletonOnly)
-    {
-        setDirty(false);
-    }
+    determineUnsetDirty(flushParams.flushLevel);
 }
 
 void PatchRecord::read()