Skip to content

Commit 6946c91

Browse files
committed
comments
1 parent 1a3b81a commit 6946c91

1 file changed

Lines changed: 10 additions & 0 deletions

File tree

include/openPMD/auxiliary/Memory.hpp

Lines changed: 10 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -49,8 +49,18 @@ namespace auxiliary
4949
*/
5050
struct WriteBuffer
5151
{
52+
/*
53+
* Sic. Have to put the unique_ptr behind a shared_ptr because
54+
* std::variant does not want immovable types.
55+
*/
5256
using UniquePtr = std::shared_ptr<UniquePtrWithLambda<void>>;
5357
using SharedPtr = std::shared_ptr<void const>;
58+
/*
59+
* Use std::any publically since some compilers have trouble with
60+
* certain uses of std::variant, so hide it from them.
61+
* Look into Memory_internal.hpp for the variant type.
62+
* https://github.com/openPMD/openPMD-api/issues/1720
63+
*/
5464
std::any m_buffer;
5565

5666
WriteBuffer();

0 commit comments

Comments
 (0)