Skip to content

Commit 84163e8

Browse files
committed
tmp: comment out calls that fail pybind11 v3.0.2
1 parent ab29b2a commit 84163e8

3 files changed

Lines changed: 26 additions & 24 deletions

File tree

src/binding/python/Iteration.cpp

Lines changed: 13 additions & 12 deletions
Original file line numberDiff line numberDiff line change
@@ -94,18 +94,19 @@ void init_Iteration(py::module &m)
9494
.def("set_dt", &Iteration::setDt<double>)
9595
.def("set_time_unit_SI", &Iteration::setTimeUnitSI)
9696

97-
.def_readwrite(
98-
"meshes",
99-
&Iteration::meshes,
100-
py::return_value_policy::copy,
101-
// garbage collection: return value must be freed before Iteration
102-
py::keep_alive<1, 0>())
103-
.def_readwrite(
104-
"particles",
105-
&Iteration::particles,
106-
py::return_value_policy::copy,
107-
// garbage collection: return value must be freed before Iteration
108-
py::keep_alive<1, 0>());
97+
// .def_readwrite(
98+
// "meshes",
99+
// &Iteration::meshes,
100+
// py::return_value_policy::copy,
101+
// // garbage collection: return value must be freed before Iteration
102+
// py::keep_alive<1, 0>())
103+
// .def_readwrite(
104+
// "particles",
105+
// &Iteration::particles,
106+
// py::return_value_policy::copy,
107+
// // garbage collection: return value must be freed before Iteration
108+
// py::keep_alive<1, 0>())
109+
;
109110

110111
add_pickle(
111112
cl, [](openPMD::Series series, std::vector<std::string> const &group) {

src/binding/python/ParticleSpecies.cpp

Lines changed: 7 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -48,12 +48,13 @@ void init_ParticleSpecies(py::module &m)
4848
return stream.str();
4949
})
5050

51-
.def_readwrite(
52-
"particle_patches",
53-
&ParticleSpecies::particlePatches,
54-
py::return_value_policy::copy,
55-
// garbage collection: return value must be freed before Series
56-
py::keep_alive<1, 0>());
51+
// .def_readwrite(
52+
// "particle_patches",
53+
// &ParticleSpecies::particlePatches,
54+
// py::return_value_policy::copy,
55+
// // garbage collection: return value must be freed before Series
56+
// py::keep_alive<1, 0>())
57+
;
5758
add_pickle(
5859
cl, [](openPMD::Series series, std::vector<std::string> const &group) {
5960
uint64_t const n_it = std::stoull(group.at(1));

src/binding/python/Series.cpp

Lines changed: 6 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -497,12 +497,12 @@ this method.
497497
.def("set_iteration_format", &Series::setIterationFormat)
498498
.def("set_name", &Series::setName)
499499

500-
.def_readwrite(
501-
"iterations",
502-
&Series::iterations,
503-
py::return_value_policy::copy,
504-
// garbage collection: return value must be freed before Series
505-
py::keep_alive<1, 0>())
500+
// .def_readwrite(
501+
// "iterations",
502+
// &Series::iterations,
503+
// py::return_value_policy::copy,
504+
// // garbage collection: return value must be freed before Series
505+
// py::keep_alive<1, 0>())
506506
.def(
507507
"read_iterations",
508508
[](Series &s) {

0 commit comments

Comments
 (0)