Record / BaseRecord Reading

Author: franzpoeschel

src/backend/BaseRecord.cpp

@@ -768,39 +768,7 @@ inline bool BaseRecord<T_elem>::scalar() const
 template <typename T_elem>
 inline void BaseRecord<T_elem>::readBase()
 {
-    using DT = Datatype;
-    Parameter<Operation::READ_ATT> aRead;
-
-    aRead.name = "unitDimension";
-    this->IOHandler()->enqueue(IOTask(this, aRead));
-    this->IOHandler()->flush(internal::defaultFlushParams);
-    if (auto val = Attribute(Attribute::from_any, *aRead.m_resource)
-                       .getOptional<std::array<double, 7>>();
-        val.has_value())
-        this->setAttribute("unitDimension", val.value());
-    else
-        throw std::runtime_error(
-            "Unexpected Attribute datatype for 'unitDimension'");
-
-    aRead.name = "timeOffset";
-    this->IOHandler()->enqueue(IOTask(this, aRead));
-    this->IOHandler()->flush(internal::defaultFlushParams);
-    if (*aRead.dtype == DT::FLOAT)
-        this->setAttribute(
-            "timeOffset",
-            Attribute(Attribute::from_any, *aRead.m_resource).get<float>());
-    else if (*aRead.dtype == DT::DOUBLE)
-        this->setAttribute(
-            "timeOffset",
-            Attribute(Attribute::from_any, *aRead.m_resource).get<double>());
-    // conversion cast if a backend reports an integer type
-    else if (auto val = Attribute(Attribute::from_any, *aRead.m_resource)
-                            .getOptional<double>();
-             val.has_value())
-        this->setAttribute("timeOffset", val.value());
-    else
-        throw std::runtime_error(
-            "Unexpected Attribute datatype for 'timeOffset'");
+    internal::ScientificDefaults<BaseRecord<T_elem>>::readDefaults();
 }
 
 template <typename T_elem>

src/backend/ScientificDefaults.cpp

@@ -261,11 +261,6 @@ void ScientificDefaults<Child>::defaults_impl()
     {
         auto dimensionality = asChild().retrieveDimensionality();
 
-        defaultAttribute("timeOffset", 0.f)
-            .withSetter(&Mesh::setTimeOffset)
-            .withReader(ensureFloatingScalar(
-                [this](auto &&val) { asChild().setTimeOffset(val); }))(wor);
-
         defaultAttribute("geometry", Mesh::Geometry::cartesian)
             .withSetter(&Mesh::setGeometry)
             .template withReader<std::string>([](Mesh &m, std::string val) {
@@ -375,6 +370,12 @@ void ScientificDefaults<Child>::defaults_impl()
                    handling for different floating types here */
                 )(wor);
 
+        defaultAttribute("timeOffset", 0.f)
+            .withSetter(&Mesh::setTimeOffset)
+            .withReader(ensureFloatingScalar([this](auto &&val) {
+                asChild().setAttribute("timeOffset", val);
+            }))(wor);
+
         addParentDefaults<BaseRecord<MeshRecordComponent>, write>();
     }
     else if constexpr (std::is_same_v<Child, Record>)
@@ -394,6 +395,12 @@ void ScientificDefaults<Child>::defaults_impl()
                     &Record::setUnitDimension)(wor);
         }
 
+        defaultAttribute("timeOffset", 0.f)
+            .withSetter(&Record::setTimeOffset)
+            .withReader(ensureFloatingScalar([this](auto &&val) {
+                asChild().setAttribute("timeOffset", val);
+            }))(wor);
+
         addParentDefaults<BaseRecord<RecordComponent>, write>();
     }
     else if constexpr (std::is_same_v<Child, PatchRecord>)
@@ -453,5 +460,7 @@ template class ScientificDefaults<PatchRecordComponent>;
 template class ScientificDefaults<ParticleSpecies>;
 template class ScientificDefaults<Record>;
 template class ScientificDefaults<BaseRecord<MeshRecordComponent>>;
+template class ScientificDefaults<BaseRecord<PatchRecordComponent>>;
+template class ScientificDefaults<BaseRecord<RecordComponent>>;
 template class ScientificDefaults<PatchRecord>;
 } // namespace openPMD::internal