clang tidy/sanitizer: Ubuntu 24.04, clang-19

Author: franzpoeschel

.github/ci/spack-envs/clangtidy_nopy_ompi_h5_ad2/spack.yaml

@@ -43,7 +43,7 @@ spack:
       variants: ~fortran
       providers:
         mpi: [openmpi]
-      compiler: [clang@14.0.0]
+      compiler: [clang@19.0.0]
 
   compilers:
   - compiler:
@@ -53,11 +53,11 @@ spack:
       modules: []
       operating_system: ubuntu22.04
       paths:
-        cc: /usr/bin/clang-14
-        cxx: /usr/bin/clang++-14
+        cc: /usr/bin/clang-19
+        cxx: /usr/bin/clang++-19
         f77: /usr/bin/gfortran
         fc: /usr/bin/gfortran
-      spec: clang@14.0.0
+      spec: clang@19.0.0
       target: x86_64
 
   config:

.github/workflows/tooling.yml

@@ -7,15 +7,15 @@ concurrency:
   cancel-in-progress: true
 
 jobs:
-  clangtidy14_nopy_ompi_h5_ad2:
+  clangtidy19_nopy_ompi_h5_ad2:
     name: clang-tidy w/o py
     runs-on: ubuntu-22.04
     if: github.event.pull_request.draft == false
     steps:
     - uses: actions/checkout@v4
     - name: Spack Cache
       uses: actions/cache@v3
-      with: {path: /opt/spack, key: clangtidy14_nopy_ompi_h5_ad2 }
+      with: {path: /opt/spack, key: clangtidy19_nopy_ompi_h5_ad2 }
     - name: Install
       run: |
         sudo apt-get update
@@ -36,24 +36,24 @@ jobs:
         cat build/clang-tidy.log
         if [[ $(wc -m <build/clang-tidy.log) -gt 1 ]]; then exit 1; fi
 
-  clangsanitizer14_py38_ompi_h5_ad2:
+  clangsanitizer19_py38_ompi_h5_ad2:
     name: Clang ASAN UBSAN
-    runs-on: ubuntu-22.04
+    runs-on: ubuntu-24.04
     if: github.event.pull_request.draft == false
     steps:
     - uses: actions/checkout@v4
     - name: Spack Cache
       uses: actions/cache@v3
-      with: {path: /opt/spack, key: clang14_nopy_ompi_h5_ad2 }
+      with: {path: /opt/spack, key: clang19_nopy_ompi_h5_ad2 }
     - name: Install
       run: |
         sudo apt-get update
-        sudo apt-get install clang-14 libc++-dev libc++abi-dev python3 gfortran libopenmpi-dev
+        sudo apt-get install clang-19 libc++-dev libc++abi-dev python3 gfortran libopenmpi-dev
         python3 -m pip install -U pip
         python3 -m pip install -U numpy
         sudo .github/workflows/dependencies/install_spack
     - name: Build
-      env: {CC: mpicc, CXX: mpic++, OMPI_CC: clang-14, OMPI_CXX: clang++-14, CXXFLAGS: -Werror, OPENPMD_HDF5_CHUNKS: none, OPENPMD_TEST_NFILES_MAX: 100}
+      env: {CC: mpicc, CXX: mpic++, OMPI_CC: clang-19, OMPI_CXX: clang++-19, CXXFLAGS: -Werror, OPENPMD_HDF5_CHUNKS: none, OPENPMD_TEST_NFILES_MAX: 100}
       run: |
         sudo ln -s "$(which cmake)" /usr/bin/cmake
         eval $(spack env activate --sh .github/ci/spack-envs/clangtidy_nopy_ompi_h5_ad2/)
@@ -72,7 +72,7 @@ jobs:
         cmake --build build --parallel 2
         export ASAN_OPTIONS=detect_stack_use_after_return=1:detect_leaks=1:check_initialization_order=true:strict_init_order=true:detect_stack_use_after_scope=1:fast_unwind_on_malloc=0
         export LSAN_OPTIONS=suppressions="$SOURCEPATH/.github/ci/sanitizer/clang/Leak.supp"
-        export LD_PRELOAD=/usr/lib/clang/14/lib/linux/libclang_rt.asan-x86_64.so
+        export LD_PRELOAD=/usr/lib/clang/19/lib/linux/libclang_rt.asan-x86_64.so
         ctest --test-dir build -E 3b --output-on-failure
         export OPENPMD_HDF5_CHUNKS="auto"
         ctest --test-dir build -R 3b --output-on-failure