Skip to content

Commit cf81295

Browse files
committed
Reviewer's suggestions
1 parent edaa266 commit cf81295

File tree

2 files changed

+5
-3
lines changed

2 files changed

+5
-3
lines changed

include/openPMD/IO/ADIOS/ParallelADIOS1IOHandlerImpl.hpp

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -58,7 +58,8 @@ namespace openPMD
5858
void extendDataset(Writable*, Parameter< Operation::EXTEND_DATASET > const&) override;
5959
void openFile(Writable*, Parameter< Operation::OPEN_FILE > const&) override;
6060
void closeFile(Writable*, Parameter< Operation::CLOSE_FILE > const&) override;
61-
void availableChunks(Writable*, Parameter< Operation::AVAILABLE_CHUNKS > &) override;void openPath(Writable*, Parameter< Operation::OPEN_PATH > const&) override;
61+
void availableChunks(Writable*, Parameter< Operation::AVAILABLE_CHUNKS > &) override;
62+
void openPath(Writable*, Parameter< Operation::OPEN_PATH > const&) override;
6263
void openDataset(Writable*, Parameter< Operation::OPEN_DATASET > &) override;
6364
void deleteFile(Writable*, Parameter< Operation::DELETE_FILE > const&) override;
6465
void deletePath(Writable*, Parameter< Operation::DELETE_PATH > const&) override;

include/openPMD/IO/AbstractIOHandlerImpl.hpp

Lines changed: 3 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -130,15 +130,16 @@ class AbstractIOHandlerImpl
130130
*/
131131
virtual void
132132
closeFile( Writable *, Parameter< Operation::CLOSE_FILE > const & ) = 0;
133+
133134
/** Report chunks that are available for loading from the dataset represented
134135
* by this writable.
135136
*
136137
* The resulting chunks should be stored into parameters.chunks.
137138
*
138139
*/
139140
virtual void
140-
availableChunks( Writable *, Parameter< Operation::AVAILABLE_CHUNKS > & )
141-
{}
141+
availableChunks( Writable *, Parameter< Operation::AVAILABLE_CHUNKS > & ) = 0;
142+
142143
/** Create a new file in physical storage, possibly overriding an existing file.
143144
*
144145
* The operation should fail if m_handler->m_frontendAccess is Access::READ_ONLY.

0 commit comments

Comments
 (0)