CMake: ADIOS1 Includes w/o SYSTEM (#1076)

* CMake: ADIOS1 Includes w/o SYSTEM

Our own source should not be included as `-isystem`, otherwise we can
get unlucky and pick up system files with the same name (seen on
Summit, where we picked up an older IOTasks.hpp for the ADIOS1 I/O
handler files).

* Fix includes: ADIOS1

Just IWYU clean-ness.

Author: ax3l

CMakeLists.txt

@@ -521,9 +521,9 @@ if(openPMD_HAVE_ADIOS1)
     target_link_libraries(openPMD.ADIOS1.Serial PUBLIC openPMD::thirdparty::mpark_variant)
     target_link_libraries(openPMD.ADIOS1.Parallel PUBLIC openPMD::thirdparty::mpark_variant)
 
-    target_include_directories(openPMD.ADIOS1.Serial SYSTEM PRIVATE
+    target_include_directories(openPMD.ADIOS1.Serial PRIVATE
         ${openPMD_SOURCE_DIR}/include ${openPMD_BINARY_DIR}/include)
-    target_include_directories(openPMD.ADIOS1.Parallel SYSTEM PRIVATE
+    target_include_directories(openPMD.ADIOS1.Parallel PRIVATE
         ${openPMD_SOURCE_DIR}/include ${openPMD_BINARY_DIR}/include)
 
     if(openPMD_HAVE_MPI)

include/openPMD/IO/IOTask.hpp

@@ -26,15 +26,14 @@
 #include "openPMD/ChunkInfo.hpp"
 #include "openPMD/Dataset.hpp"
 #include "openPMD/IterationEncoding.hpp"
+#include "openPMD/Streaming.hpp"
 
 #include <memory>
 #include <map>
 #include <string>
 #include <utility>
 #include <vector>
 
-#include "openPMD/Streaming.hpp"
-
 
 namespace openPMD
 {

src/IO/ADIOS/ADIOS1IOHandler.cpp

@@ -26,8 +26,10 @@
 #   include "openPMD/auxiliary/DerefDynamicCast.hpp"
 #   include "openPMD/auxiliary/Memory.hpp"
 #   include "openPMD/auxiliary/StringManip.hpp"
+#   include "openPMD/IO/AbstractIOHandlerImpl.hpp"
 #   include "openPMD/IO/ADIOS/ADIOS1Auxiliary.hpp"
 #   include "openPMD/IO/ADIOS/ADIOS1FilePosition.hpp"
+#   include "openPMD/IO/IOTask.hpp"
 #   include <adios.h>
 #   include <iostream>
 #   include <memory>

src/IO/ADIOS/ParallelADIOS1IOHandler.cpp

@@ -26,8 +26,10 @@
 #   include "openPMD/auxiliary/DerefDynamicCast.hpp"
 #   include "openPMD/auxiliary/Memory.hpp"
 #   include "openPMD/auxiliary/StringManip.hpp"
+#   include "openPMD/IO/AbstractIOHandlerImpl.hpp"
 #   include "openPMD/IO/ADIOS/ADIOS1Auxiliary.hpp"
 #   include "openPMD/IO/ADIOS/ADIOS1FilePosition.hpp"
+#   include "openPMD/IO/IOTask.hpp"
 #   include <adios.h>
 #   include <cstring>
 #   include <map>