Add defaults for Iteration class

Author: franzpoeschel

src/Iteration.cpp

@@ -53,9 +53,6 @@ using internal::DeferredParseAccess;
 Iteration::Iteration() : Attributable(NoInit())
 {
     setData(std::make_shared<Data_t>());
-    setTime(static_cast<double>(0));
-    setDt(static_cast<double>(1));
-    setTimeUnitSI(1);
     meshes.writable().ownKeyWithinParent = "meshes";
     particles.writable().ownKeyWithinParent = "particles";
 }

src/backend/ScientificDefaults.cpp

@@ -64,6 +64,8 @@ void ScientificDefaults<Child>::addDefaultFor_resolveValue(
             return get_value;
         }
     }();
+    constexpr bool debug = true;
+    if constexpr (debug)
     {
         std::cout << "\tInitializing default for '" << key << "' = '";
         if constexpr (
@@ -167,7 +169,13 @@ void ScientificDefaults<Child>::addDefaults()
     std::cout << "Adding defaults for '" << asChild().myPath().openPMDPath()
               << "'" << std::endl;
 
-    if constexpr (std::is_same_v<Child, Mesh>)
+    if constexpr (std::is_same_v<Child, Iteration>)
+    {
+        addDefaultFor("time", 0., &Iteration::setTime);
+        addDefaultFor("dt", 1., &Iteration::setDt);
+        addDefaultFor("timeUnitSI", 1.0, &Iteration::setTimeUnitSI);
+    }
+    else if constexpr (std::is_same_v<Child, Mesh>)
     {
         auto dimensionality = asChild().retrieveDimensionality();
 

test/CoreTest.cpp

@@ -618,6 +618,9 @@ TEST_CASE("iteration_default_test", "[core]")
 
     Iteration &i = o.iterations[42];
 
+    REQUIRE(i.numAttributes() == 0);
+
+    i.close();
     REQUIRE(i.time<double>() == static_cast<double>(0));
     REQUIRE(i.dt<double>() == static_cast<double>(1));
     REQUIRE(i.timeUnitSI() == static_cast<double>(1));