Clang Tidy and Sanitizer: Use clang-19 on Ubuntu 24.04 (#1783)

* clang tidy/sanitizer: Ubuntu 24.04, clang-19

* ok, back to clanag-14

* Upgrade spack to 1.0.1 for tidy runs

* ???

* Some fixes

* sudo: preserve env

* Switch back to clang-19

* Specify C and Cxx providers

* hmmm

* aaaahhhh

* Huh?

* hehe yes

* Use spack-default cache

* Remove gcc specification

does not work

* Fix prefixes, fix gcc

* fixes for runs

* clang-tidy gespräche

* further clang-tidy fixes

Author: franzpoeschel

.clang-tidy

@@ -2,5 +2,5 @@
 # FIXME: all performance-* reports
 # FIXME: all cert-* reports
 # FIXME: all bugprone-* reports
-Checks: -*,bugprone-*,-bugprone-unhandled-self-assignment,-bugprone-parent-virtual-call,-bugprone-narrowing-conversions,-bugprone-exception-escape,-bugprone-string-literal-with-embedded-nul,cppcoreguidelines-slicing,mpi-*,readability-non-const-parameter,performance-*,modernize-*,-modernize-use-trailing-return-type,-modernize-use-bool-literals,-modernize-avoid-c-arrays,-modernize-use-auto,-modernize-return-braced-init-list,-bugprone-easily-swappable-parameters
+Checks: -*,bugprone-*,-bugprone-unhandled-self-assignment,-bugprone-parent-virtual-call,-bugprone-narrowing-conversions,-bugprone-exception-escape,-bugprone-string-literal-with-embedded-nul,cppcoreguidelines-slicing,mpi-*,readability-non-const-parameter,performance-*,-performance-avoid-endl,modernize-*,-modernize-use-trailing-return-type,-modernize-use-bool-literals,-modernize-avoid-c-arrays,-modernize-use-auto,-modernize-return-braced-init-list,-bugprone-easily-swappable-parameters,-bugprone-chained-comparison
 HeaderFilterRegex: '((^(?!\/share\/openPMD\/).*)*include\/openPMD\/.+\.hpp|src\/^(?!binding).+\.cpp$)'

.github/ci/spack-envs/clangtidy_nopy_ompi_h5_ad2/spack.yaml

@@ -14,54 +14,78 @@ spack:
   packages:
     adios2:
       variants: ~zfp ~sz ~png ~dataman ~python ~fortran ~ssc ~shared ~bzip2 ~mgard
+
     c-blosc2:
       # snappy broken on CMake 4.0
       # fixed snappy not yet deployed to a Spack release
       variants: ~snappy
+
     cmake:
       externals:
-      - spec: cmake@3.31.5
-        prefix: /usr
+      - spec: cmake@3.31.8
+        prefix: /usr/local
       buildable: False
+
     openmpi:
       externals:
-      - spec: openmpi@4.1.2
+      - spec: openmpi@4.1.6
         prefix: /usr
       buildable: False
+
     perl:
       externals:
-      - spec: perl@5.34.0
+      - spec: perl@5.38.2
         prefix: /usr
       buildable: False
+
     python:
       externals:
-      - spec: python@3.10.12
+      - spec: python@3.12.3
         prefix: /usr
       buildable: False
+
     all:
       target: [x86_64]
       variants: ~fortran
       providers:
         mpi: [openmpi]
-      compiler: [clang@14.0.0]
+        cc: [llvm]
+        cxx: [llvm]
+        fortran: [gcc]
+
+    llvm:
+      externals:
+      - spec: llvm@19.1.1
+        prefix: /usr
+        paths:
+          cc: /usr/bin/clang-19
+          cxx: /usr/bin/clang++-19
+        modules: []
+        environment: {}
+        extra_rpaths: []
+      buildable: False
+
+    gcc:
+      externals:
+      - spec: gcc@13.3.0
+        prefix: /usr
+        paths:
+          cc: /usr/bin/gcc
+          cxx: /usr/bin/g++
+          fortran: /usr/bin/gfortran
+        modules: []
+        environment: {}
+        extra_rpaths: []
+      buildable: False
 
-  compilers:
-  - compiler:
-      environment: {}
-      extra_rpaths: []
-      flags: {}
-      modules: []
-      operating_system: ubuntu22.04
-      paths:
-        cc: /usr/bin/clang-14
-        cxx: /usr/bin/clang++-14
-        f77: /usr/bin/gfortran
-        fc: /usr/bin/gfortran
-      spec: clang@14.0.0
-      target: x86_64
+    gcc-runtime:
+      buildable: false
+      externals:
+        - spec: gcc-runtime@13.3.0
+          prefix: /usr
 
   config:
     build_jobs: 2
 
   mirrors:
-    E4S: https://cache.e4s.io
+    spack-public: https://mirror.spack.io

.github/workflows/dependencies/install_spack

@@ -3,7 +3,7 @@
 
 set -eu -o pipefail
 
-spack_ver="0.22.3"
+spack_ver="${SPACK_VER:-0.22.3}"
 
 cd /opt
 if [[ -d spack && ! -f spack_${spack_ver} ]]

.github/workflows/tooling.yml

@@ -7,20 +7,21 @@ concurrency:
   cancel-in-progress: true
 
 jobs:
-  clangtidy14_nopy_ompi_h5_ad2:
+  clangtidy19_nopy_ompi_h5_ad2:
     name: clang-tidy w/o py
-    runs-on: ubuntu-22.04
+    runs-on: ubuntu-24.04
     if: github.event.pull_request.draft == false
     steps:
     - uses: actions/checkout@v4
     - name: Spack Cache
       uses: actions/cache@v3
-      with: {path: /opt/spack, key: clangtidy14_nopy_ompi_h5_ad2 }
+      with: {path: /opt/spack, key: clangtidy19_nopy_ompi_h5_ad2 }
     - name: Install
       run: |
         sudo apt-get update
         sudo apt-get install clang clang-tidy gfortran libopenmpi-dev python-is-python3
-        sudo .github/workflows/dependencies/install_spack
+        SPACK_VER=1.0.1 sudo -E .github/workflows/dependencies/install_spack
+        echo "SPACK VERSION: $(spack --version)"
     - name: Build
       env: {CC: clang, CXX: clang++}
       run: |
@@ -36,32 +37,31 @@ jobs:
         cat build/clang-tidy.log
         if [[ $(wc -m <build/clang-tidy.log) -gt 1 ]]; then exit 1; fi
 
-  clangsanitizer14_py38_ompi_h5_ad2:
+  clangsanitizer19_py38_ompi_h5_ad2:
     name: Clang ASAN UBSAN
-    runs-on: ubuntu-22.04
+    runs-on: ubuntu-24.04
     if: github.event.pull_request.draft == false
     steps:
     - uses: actions/checkout@v4
     - name: Spack Cache
       uses: actions/cache@v3
-      with: {path: /opt/spack, key: clang14_nopy_ompi_h5_ad2 }
+      with: {path: /opt/spack, key: clang19_nopy_ompi_h5_ad2 }
     - name: Install
       run: |
         sudo apt-get update
-        sudo apt-get install clang-14 libc++-dev libc++abi-dev python3 gfortran libopenmpi-dev
-        python3 -m pip install -U pip
-        python3 -m pip install -U numpy
-        sudo .github/workflows/dependencies/install_spack
+        sudo apt-get install clang-19 libc++-dev libc++abi-dev python3 gfortran libopenmpi-dev python3-numpy
+        SPACK_VER=1.0.1 sudo -E .github/workflows/dependencies/install_spack
+        echo "SPACK VERSION: $(spack --version)"
     - name: Build
-      env: {CC: mpicc, CXX: mpic++, OMPI_CC: clang-14, OMPI_CXX: clang++-14, CXXFLAGS: -Werror, OPENPMD_HDF5_CHUNKS: none, OPENPMD_TEST_NFILES_MAX: 100}
+      env: {CC: mpicc, CXX: mpic++, OMPI_CC: clang-19, OMPI_CXX: clang++-19, CXXFLAGS: -Werror, OPENPMD_HDF5_CHUNKS: none, OPENPMD_TEST_NFILES_MAX: 100}
       run: |
         sudo ln -s "$(which cmake)" /usr/bin/cmake
         eval $(spack env activate --sh .github/ci/spack-envs/clangtidy_nopy_ompi_h5_ad2/)
         spack install
         SOURCEPATH="$(pwd)"
         share/openPMD/download_samples.sh build
         export LDFLAGS="${LDFLAGS} -fsanitize=address,undefined -shared-libsan"
-        export CXXFLAGS="${CXXFLAGS} -fsanitize=address,undefined -shared-libsan"
+        export CXXFLAGS="${CXXFLAGS} -fsanitize=address,undefined -shared-libsan -DOMPI_SKIP_MPICXX"
         cmake -S . -B build               \
           -DopenPMD_USE_MPI=ON            \
           -DopenPMD_USE_PYTHON=ON         \
@@ -72,7 +72,7 @@ jobs:
         cmake --build build --parallel 2
         export ASAN_OPTIONS=detect_stack_use_after_return=1:detect_leaks=1:check_initialization_order=true:strict_init_order=true:detect_stack_use_after_scope=1:fast_unwind_on_malloc=0
         export LSAN_OPTIONS=suppressions="$SOURCEPATH/.github/ci/sanitizer/clang/Leak.supp"
-        export LD_PRELOAD=/usr/lib/clang/14/lib/linux/libclang_rt.asan-x86_64.so
+        export LD_PRELOAD=/usr/lib/clang/19/lib/linux/libclang_rt.asan-x86_64.so
         ctest --test-dir build -E 3b --output-on-failure
         export OPENPMD_HDF5_CHUNKS="auto"
         ctest --test-dir build -R 3b --output-on-failure

examples/8b_benchmark_read_parallel.cpp

@@ -135,7 +135,6 @@ class Timer
     ~Timer()
     {
         MPI_Barrier(MPI_COMM_WORLD);
-        std::string tt = "~" + m_Tag;
         // MemoryProfiler (m_Rank, tt.c_str());
         m_End = std::chrono::system_clock::now();
 

include/openPMD/IO/HDF5/HDF5IOHandlerImpl.hpp

@@ -132,6 +132,8 @@ class HDF5IOHandlerImpl : public AbstractIOHandlerImpl
         hid_t id;
     };
     std::optional<File> getFile(Writable *);
+    File
+    requireFile(std::string const &functionName, Writable *, bool checkParent);
 }; // HDF5IOHandlerImpl
 #else
 class HDF5IOHandlerImpl

include/openPMD/IO/JSON/JSONIOHandlerImpl.hpp

@@ -525,9 +525,7 @@ class JSONIOHandlerImpl : public AbstractIOHandlerImpl
     };
 
     template <typename T>
-    struct JsonToCpp<
-        T,
-        typename std::enable_if<std::is_floating_point<T>::value>::type>
+    struct JsonToCpp<T, typename std::enable_if_t<std::is_floating_point_v<T>>>
     {
         T operator()(nlohmann::json const &);
     };

include/openPMD/backend/BaseRecord.hpp

@@ -317,7 +317,7 @@ class BaseRecord
     template <class InputIt>
     void insert(InputIt first, InputIt last);
     void insert(std::initializer_list<value_type> ilist);
-    void swap(BaseRecord &other);
+    void swap(BaseRecord &other) noexcept;
     bool contains(key_type const &key) const;
     template <class... Args>
     auto emplace(Args &&...args) -> std::pair<iterator, bool>;

src/IO/ADIOS/ADIOS2File.cpp

@@ -28,6 +28,7 @@
 #include "openPMD/auxiliary/Environment.hpp"
 #include "openPMD/auxiliary/StringManip.hpp"
 
+#include <cstdint>
 #include <optional>
 #include <stdexcept>
 
@@ -317,7 +318,7 @@ namespace
         return false;
     }
 
-    enum class PerstepParsing
+    enum class PerstepParsing : std::uint8_t
     {
         Supported,
         Unsupported,
@@ -1086,7 +1087,7 @@ void ADIOS2File::flush_impl(ADIOS2FlushParams flushParams, bool writeLatePuts)
 #if ADIOS2_VERSION_MAJOR * 1000000000 + ADIOS2_VERSION_MINOR * 100000000 +     \
         ADIOS2_VERSION_PATCH * 1000000 + ADIOS2_VERSION_TWEAK >=               \
     2701001223
-        enum class CleanedFlushTarget
+        enum class CleanedFlushTarget : std::uint8_t
         {
             Buffer,
             Disk,

src/IO/ADIOS/ADIOS2IOHandler.cpp

@@ -1371,7 +1371,7 @@ namespace
          */
         using rep = detail::AttributeTypes<bool>::rep;
 
-        if constexpr (std::is_same<T, rep>::value)
+        if constexpr (std::is_same_v<T, rep>)
         {
             auto attr = getAttribute.template call<rep>(name);
             if (!attr)
@@ -2239,7 +2239,6 @@ namespace detail
         auto file = impl->refreshFileFromParent(
             writable, /* preferParentFile = */ false);
         auto fullName = impl->nameOfAttribute(writable, parameters.name);
-        auto prefix = impl->filePositionToString(pos);
 
         auto &filedata = impl->getFileData(
             file, ADIOS2IOHandlerImpl::IfFileNotOpen::ThrowError);