Skip to content

Fix use after free in ADIOS1IOHandler#1224

Merged
ax3l merged 1 commit into
openPMD:devfrom
franzpoeschel:fix-adios1-memory
Mar 13, 2022
Merged

Fix use after free in ADIOS1IOHandler#1224
ax3l merged 1 commit into
openPMD:devfrom
franzpoeschel:fix-adios1-memory

Conversation

@franzpoeschel
Copy link
Copy Markdown
Contributor

Extracted from #1197

There is currently a (low-key) use after free in ADIOS1, happening if a user calls loadChunk() without storing the buffer. #1197 will add a test.

Copy link
Copy Markdown
Member

@ax3l ax3l left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀 ✨

@ax3l ax3l self-assigned this Mar 13, 2022
@ax3l ax3l merged commit 272b137 into openPMD:dev Mar 13, 2022
@ax3l ax3l added this to the 0.14.5 milestone Mar 13, 2022
@ax3l
Copy link
Copy Markdown
Member

ax3l commented May 25, 2022

I have problems backporting this to release-0.14.5 branch due to the change in CommonADIOS1IOHandler.hpp/cpp

@ax3l ax3l modified the milestones: 0.14.5, 0.14.6 May 25, 2022
@ax3l ax3l modified the milestones: 0.14.6, 0.14.5 Jun 6, 2022
@ax3l
Copy link
Copy Markdown
Member

ax3l commented Jun 6, 2022

Applied to 0.14.5 via ax3l#6 🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants