Skip to content

Safeguards for READ_LINEAR mode #1753

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
franzpoeschel merged 2 commits into from
May 6, 2025
Merged

Safeguards for READ_LINEAR mode #1753

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
316b8e0
Check that the Series has been parsed
franzpoeschel May 6, 2025
8ad5d64
Do not attempt to read all steps when parse preference is per step
franzpoeschel May 6, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 15 additions & 1 deletion src/Series.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1244,6 +1244,17 @@ std::future<void> Series::flush_impl(
internal::FlushParams const &flushParams,
bool flushIOHandler)
{
if (!written() && access::readOnly(IOHandler()->m_frontendAccess) &&
IOHandler()->m_work.empty())
{
throw error::WrongAPIUsage(
"Attempting to flush the Series in Read mode even though no "
"operation has been performed yet. If this error occurs to you in "
"Access::READ_LINEAR mode, then either try using "
"Series::parseBase() or use Series::snapshots() / "
"Series::readIterations() to access the first Iteration. If this "
"occurs in Access::READ_ONLY, then this is likely a bug.");
}
IOHandler()->m_lastFlushSuccessful = true;
try
{
Expand Down Expand Up @@ -3514,7 +3525,10 @@ bool Series::randomAccessSteps() const
}
return false;
};
return iterationEncoding() == IterationEncoding::variableBased &&
return get().m_parsePreference.value_or(
internal::ParsePreference::UpFront) ==
internal::ParsePreference::UpFront &&
iterationEncoding() == IterationEncoding::variableBased &&
randomAccess(IOHandler()->m_backendAccess);
}

Expand Down
Loading