From d5d6e0c8ee71a32736066d97ae62ddd3500b6980 Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?Franz=20P=C3=B6schel?= <franz.poeschel@gmail.com>
Date: Mon, 5 May 2025 22:05:27 +0200
Subject: [PATCH 1/2] Fix weird Hipcc error

---
 .../openPMD/snapshots/RandomAccessIterator.hpp |  7 ++++---
 src/snapshots/RandomAccessIterator.cpp         | 18 ------------------
 2 files changed, 4 insertions(+), 21 deletions(-)

diff --git a/include/openPMD/snapshots/RandomAccessIterator.hpp b/include/openPMD/snapshots/RandomAccessIterator.hpp
index 1487d64aa7..b339fea371 100644
--- a/include/openPMD/snapshots/RandomAccessIterator.hpp
+++ b/include/openPMD/snapshots/RandomAccessIterator.hpp
@@ -66,10 +66,11 @@ class RandomAccessIterator
     RandomAccessIterator(RandomAccessIterator &&other) noexcept(
         noexcept(iterator_t(std::declval<iterator_t &&>())));
 
-    RandomAccessIterator &operator=(RandomAccessIterator const &other);
     RandomAccessIterator &
-    operator=(RandomAccessIterator &&other) noexcept(noexcept(
-        std::declval<iterator_t>().operator=(std::declval<iterator_t &&>())));
+    operator=(RandomAccessIterator const &other) = default;
+    RandomAccessIterator &operator=(RandomAccessIterator &&other) noexcept(
+        noexcept(std::declval<iterator_t>().operator=(
+            std::declval<iterator_t &&>()))) = default;
 
     auto operator*() -> value_type &;
     auto operator*() const -> value_type const &;
diff --git a/src/snapshots/RandomAccessIterator.cpp b/src/snapshots/RandomAccessIterator.cpp
index 689c675db7..904233904a 100644
--- a/src/snapshots/RandomAccessIterator.cpp
+++ b/src/snapshots/RandomAccessIterator.cpp
@@ -9,24 +9,6 @@ inline RandomAccessIterator<iterator_t>::RandomAccessIterator(iterator_t it)
 template <typename iterator_t>
 RandomAccessIterator<iterator_t>::~RandomAccessIterator() = default;
 
-template <typename iterator_t>
-RandomAccessIterator<iterator_t>::RandomAccessIterator(
-    RandomAccessIterator const &other) = default;
-template <typename iterator_t>
-RandomAccessIterator<iterator_t>::RandomAccessIterator(
-    RandomAccessIterator
-        &&other) noexcept(noexcept(iterator_t(std::declval<iterator_t &&>()))) =
-    default;
-template <typename iterator_t>
-RandomAccessIterator<iterator_t> &RandomAccessIterator<iterator_t>::operator=(
-    RandomAccessIterator const &other) = default;
-template <typename iterator_t>
-RandomAccessIterator<iterator_t> &RandomAccessIterator<iterator_t>::operator=(
-    RandomAccessIterator
-        &&other) noexcept(noexcept(std::declval<iterator_t>().
-                                   operator=(std::declval<iterator_t &&>()))) =
-    default;
-
 template <typename iterator_t>
 auto RandomAccessIterator<iterator_t>::operator*() -> value_type &
 {

From 97a5fcb37d0a173e6e1f0072a186ab12becdcfe7 Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?Franz=20P=C3=B6schel?= <franz.poeschel@gmail.com>
Date: Tue, 6 May 2025 18:07:48 +0200
Subject: [PATCH 2/2] Fix

---
 include/openPMD/snapshots/RandomAccessIterator.hpp | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/include/openPMD/snapshots/RandomAccessIterator.hpp b/include/openPMD/snapshots/RandomAccessIterator.hpp
index b339fea371..6ad769a757 100644
--- a/include/openPMD/snapshots/RandomAccessIterator.hpp
+++ b/include/openPMD/snapshots/RandomAccessIterator.hpp
@@ -62,9 +62,9 @@ class RandomAccessIterator
 
     ~RandomAccessIterator() override;
 
-    RandomAccessIterator(RandomAccessIterator const &other);
+    RandomAccessIterator(RandomAccessIterator const &other) = default;
     RandomAccessIterator(RandomAccessIterator &&other) noexcept(
-        noexcept(iterator_t(std::declval<iterator_t &&>())));
+        noexcept(iterator_t(std::declval<iterator_t &&>()))) = default;
 
     RandomAccessIterator &
     operator=(RandomAccessIterator const &other) = default;