Clang on Windows: Fix build errors#1769
Merged
franzpoeschel merged 3 commits intoopenPMD:devfrom Jul 14, 2025
Merged
Conversation
3828a45 to
a3f494e
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Seen this error in multiple PRs:
::auxiliary::ForEachType< ::internal::DefineSeriesConstructorPerPathType, // First tuple components are eligible types for the path argument // second component for the config argument // py::object needs to always come last, as a catch-all pattern #if openPMD_USE_FILESYSTEM_HEADER std::tuple<std::string, std::string>, std::tuple<std::string, std::filesystem::path>, std::tuple<std::string, py::object>, std::tuple<std::filesystem::path, std::string>, std::tuple<std::filesystem::path, std::filesystem::path>, std::tuple<std::filesystem::path, py::object> #else std::tuple<std::string, std::string>, std::tuple<std::string, py::object>, std::tuple<py::object, std::string>, std::tuple<py::object, py::object> #endif >::template call(cl); // line 390, this is a template, but Clang on Windows no longer believes soFirst commit is empty to verify that this affects dev already. Second will push a workaround.
This also uncovered a deprecated API call in Pybind.