Skip to content

HIP: Fix host-only constructors #1801

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
ax3l merged 5 commits into from
Dec 2, 2025
Merged

HIP: Fix host-only constructors #1801

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
96ad681
Revert "Workaround for Hipcc error (reference to host function in hos…
franzpoeschel Nov 6, 2025
e453cd1
Add __host__ directives where needed
franzpoeschel Nov 6, 2025
673796b
Annotate Compiler & Issue Number
ax3l Nov 11, 2025
7a719b7
[pre-commit.ci] auto fixes from pre-commit.com hooks
pre-commit-ci[bot] Nov 11, 2025
96c0504
Formatting
ax3l Dec 2, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 5 additions & 6 deletions include/openPMD/snapshots/RandomAccessIterator.hpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -72,15 +72,14 @@ class RandomAccessIterator

~RandomAccessIterator() override;

RandomAccessIterator(RandomAccessIterator const &other) = default;
RandomAccessIterator(RandomAccessIterator const &other);
RandomAccessIterator(RandomAccessIterator &&other) noexcept(
noexcept(iterator_t(std::declval<iterator_t &&>()))) = default;
noexcept(iterator_t(std::declval<iterator_t &&>())));

RandomAccessIterator &operator=(RandomAccessIterator const &other);
RandomAccessIterator &
operator=(RandomAccessIterator const &other) = default;
RandomAccessIterator &operator=(RandomAccessIterator &&other) noexcept(
noexcept(std::declval<iterator_t>().operator=(
std::declval<iterator_t &&>()))) = default;
operator=(RandomAccessIterator &&other) noexcept(noexcept(
std::declval<iterator_t>().operator=(std::declval<iterator_t &&>())));

auto operator*() -> value_type &;
auto operator*() const -> value_type const &;
Expand Down
3 changes: 3 additions & 0 deletions src/auxiliary/UniquePtr.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -65,6 +65,9 @@ namespace auxiliary
} // namespace auxiliary

template <typename T>
#ifdef __HIPCC__ // ROCm 6.2.4 issue, see #1797
__host__
#endif
UniquePtrWithLambda<T>::UniquePtrWithLambda() = default;

template <typename T>
Expand Down
3 changes: 3 additions & 0 deletions src/backend/BaseRecord.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -56,6 +56,9 @@ namespace internal
typename T_BaseRecord_,
typename T_BaseRecordData_,
typename T_BaseIterator>
#ifdef __HIPCC__ // ROCm 6.2.4 issue, see #1797
__host__
#endif
ScalarIterator<T_BaseRecord_, T_BaseRecordData_, T_BaseIterator>::
ScalarIterator() = default;

Expand Down
27 changes: 27 additions & 0 deletions src/snapshots/RandomAccessIterator.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,6 +9,33 @@ inline RandomAccessIterator<iterator_t>::RandomAccessIterator(iterator_t it)
template <typename iterator_t>
RandomAccessIterator<iterator_t>::~RandomAccessIterator() = default;

template <typename iterator_t>
#ifdef __HIPCC__ // ROCm 6.2.4 issue, see #1797
__host__
#endif
RandomAccessIterator<iterator_t>::RandomAccessIterator(
RandomAccessIterator const &other) = default;

template <typename iterator_t>
Comment thread
ax3l marked this conversation as resolved.
#ifdef __HIPCC__ // ROCm 6.2.4 issue, see #1797
__host__
#endif
RandomAccessIterator<iterator_t>::RandomAccessIterator(
RandomAccessIterator
&&other) noexcept(noexcept(iterator_t(std::declval<iterator_t &&>()))) =
default;

template <typename iterator_t>
RandomAccessIterator<iterator_t> &RandomAccessIterator<iterator_t>::operator=(
RandomAccessIterator const &other) = default;
Comment thread
ax3l marked this conversation as resolved.

template <typename iterator_t>
RandomAccessIterator<iterator_t> &RandomAccessIterator<iterator_t>::operator=(
RandomAccessIterator
&&other) noexcept(noexcept(std::declval<iterator_t>().
operator=(std::declval<iterator_t &&>()))) =
default;

template <typename iterator_t>
auto RandomAccessIterator<iterator_t>::operator*() -> value_type &
{
Expand Down
Loading