Skip to content

Fixes for ADIOS2 v2.11 #1804

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
franzpoeschel merged 4 commits into from
Nov 17, 2025
Merged

Fixes for ADIOS2 v2.11 #1804

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
e96aa28
No more changed dimensions in v encoding
franzpoeschel Nov 10, 2025
401e706
Link to renamed ADIOS2 targets
franzpoeschel Nov 11, 2025
4bf7298
Workaround the bug for now
franzpoeschel Nov 11, 2025
46ac004
Revert "Workaround the bug for now"
franzpoeschel Nov 14, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 11 additions & 3 deletions CMakeLists.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -544,10 +544,18 @@ endif()

# ADIOS2 Backend
if(openPMD_HAVE_ADIOS2)
if(openPMD_HAVE_MPI)
target_link_libraries(openPMD PUBLIC adios2::cxx11_mpi)
if(${ADIOS2_VERSION} VERSION_GREATER_EQUAL 2.11.0)
if(openPMD_HAVE_MPI)
target_link_libraries(openPMD PUBLIC adios2::cxx_mpi)
else()
target_link_libraries(openPMD PUBLIC adios2::cxx)
endif()
else()
target_link_libraries(openPMD PUBLIC adios2::cxx11)
if(openPMD_HAVE_MPI)
target_link_libraries(openPMD PUBLIC adios2::cxx11_mpi)
else()
target_link_libraries(openPMD PUBLIC adios2::cxx11)
endif()
endif()
endif()

Expand Down
9 changes: 5 additions & 4 deletions test/SerialIOTest.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5853,10 +5853,11 @@ void variableBasedSeries(std::string const &file)

iteration.setAttribute("changing_value", i);

// this tests changing extents and dimensionalities
// across iterations
// this tests changing extents across iterations
// ADIOS2 does not support changing the dimensionality
// (older versions used to somewhat support it, but not really)
auto E_y = iteration.meshes["E"]["y"];
unsigned dimensionality = i % 3 + 1;
unsigned dimensionality = 3;
unsigned len = i + 1;
Extent changingExtent(dimensionality, len);
E_y.resetDataset({openPMD::Datatype::INT, changingExtent});
Expand Down Expand Up @@ -5984,7 +5985,7 @@ void variableBasedSeries(std::string const &file)
}

auto E_y = iteration.meshes["E"]["y"];
unsigned dimensionality = index % 3 + 1;
unsigned dimensionality = 3;
unsigned len = index + 1;
Extent changingExtent(dimensionality, len);
REQUIRE(E_y.getExtent() == changingExtent);
Expand Down
Loading