Make a few changes suggested by ruff in examples and tests

Author: tleonhardt

examples/argparse_example.py

@@ -34,7 +34,7 @@ def __init__(self, color: str) -> None:
             "cmd2 has awesome decorators to make it easy to use Argparse to parse command arguments", style=color
         )
 
-    ## ------ Basic examples of using argparse for command argument parsing -----
+    # ------ Basic examples of using argparse for command argument parsing -----
 
     # do_fsize parser
     fsize_parser = cmd2.Cmd2ArgumentParser(description="Obtain the size of a file")
@@ -79,7 +79,7 @@ def do_pow(self, args: argparse.Namespace) -> None:
         """
         self.poutput(f"{args.base} ** {args.exponent} == {args.base**args.exponent}")
 
-    ## ------ Examples displaying how argparse arguments are passed to commands by printing them out -----
+    # ------ Examples displaying how argparse arguments are passed to commands by printing them out -----
 
     argprint_parser = cmd2.Cmd2ArgumentParser()
     argprint_parser.add_argument("-p", "--piglatin", action="store_true", help="atinLay")
@@ -104,7 +104,7 @@ def do_print_unknown(self, args: argparse.Namespace, unknown: list[str]) -> None
         """Print the arpgarse argument list this command was called with, including unknown arguments."""
         self.poutput(f"print_unknown was called with the following arguments\n\tknown: {args!r}\n\tunknown: {unknown}")
 
-    ## ------ Examples demonstrating how to use argparse subcommands -----
+    # ------ Examples demonstrating how to use argparse subcommands -----
 
     # create the top-level parser for the base command
     calculate_parser = cmd2.Cmd2ArgumentParser(description="Perform simple mathematical calculations.")

examples/paged_output.py

@@ -2,6 +2,7 @@
 """A simple example demonstrating the using paged output via the ppaged() method."""
 
 import os
+import pathlib
 
 import cmd2
 
@@ -16,8 +17,7 @@ def page_file(self, file_path: str, chop: bool = False) -> None:
         """Helper method to prevent having too much duplicated code."""
         filename = os.path.expanduser(file_path)
         try:
-            with open(filename) as f:
-                text = f.read()
+            text = pathlib.Path(filename).read_text()
             self.ppaged(text, chop=chop)
         except OSError as ex:
             self.pexcept(f"Error reading {filename!r}: {ex}")

tests/test_argparse_utils.py

@@ -322,7 +322,7 @@ def test_register_argparse_argument_parameter() -> None:
         with pytest.raises(KeyError, match=expected_err):
             register_argparse_argument_parameter("colliding_param")
     finally:
-        delattr(argparse.Action, "get_colliding_param")
+        del argparse.Action.get_colliding_param
 
     # Test collision with internal attribute
     try:

tests/test_commandset.py

@@ -348,7 +348,7 @@ def test_load_commandset_errors(manual_command_sets_app, capsys) -> None:
     assert "Fruits" not in cmds_cats
     assert not manual_command_sets_app._installed_command_sets
 
-    delattr(manual_command_sets_app, "do_durian")
+    del manual_command_sets_app.do_durian
 
     # pre-create intentionally conflicting macro and alias names
     manual_command_sets_app.app_cmd("macro create apple run_pyscript")

tests/test_run_pyscript.py

@@ -1,6 +1,7 @@
 """Unit/functional testing for run_pytest in cmd2"""
 
 import os
+import pathlib
 from unittest import (
     mock,
 )
@@ -245,8 +246,7 @@ def test_run_pyscript_print_redirection(base_app, request, tmp_path, capsys) ->
     out, err = capsys.readouterr()
 
     # Verify the output file contains what we expect from print()
-    with open(out_file) as f:
-        content = f.read()
+    content = pathlib.Path(out_file).read_text()
 
     # Look for everything written to self.stdout
     assert len(content.splitlines()) == 4

tests/test_utils.py

@@ -1,5 +1,6 @@
 """Unit testing for cmd2/utils.py module."""
 
+import math
 import os
 import signal
 import sys
@@ -281,7 +282,7 @@ def test_to_bool_int() -> None:
 def test_to_bool_float() -> None:
     assert cu.to_bool(2.35)
     assert cu.to_bool(0.25)
-    assert cu.to_bool(-3.1415)
+    assert cu.to_bool(-math.pi)
     assert not cu.to_bool(0)