Report error about future timestamps#147
Merged
Merged
Conversation
Same as in openSUSE/obs-build#1047
The latest .changes entry is used for SOURCE_DATE_EPOCH, which is expected to always be in the past for mtime-clamping to work. Note that the 'break' had to be dropped, because it skipped the other checks if the line started with a day-of-week (e.g. Sun)
Vogtinator
reviewed
May 13, 2025
| esac | ||
| DATE=`date +%s --date "$DATESTR" 2> /dev/null` | ||
| test $? -gt 0 -o -z "$DATE" -o "$LAST_IS_YEAR" != true && { | ||
| test $? -gt 0 -o -z "$DATE" -o "$LAST_IS_YEAR" != true -o "$DATE" -gt "$now" && { |
Member
There was a problem hiding this comment.
If you touch this line anyway, could you convert it into more readable if [ ... ] || [ ... ]; then syntax? Currently it's more perl than sh...
Vogtinator
approved these changes
May 13, 2025
dirkmueller
approved these changes
May 14, 2025
Contributor
|
regression detected: #149 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Report error about future timestamps
The latest
.changesentry is used forSOURCE_DATE_EPOCH,which is expected to always be in the past for mtime-clamping to work.
Note that the
breakhad to be dropped, because it skipped the other checksif the line started with a day-of-week (e.g. Sun)