Being able to handle git managed sources#148
Conversation
|
the part about gitmodules is fine the spec parser in the build package already knows about createarchive, we just need to add handing this to spec_query when doing print_sources, probably what's in "moveassets" ... if someone can tell me what that field is meant to be |
|
it is testing for existens of either the obscpio file or a directory, not just assuming they are there. But yes, we can try to use build script parser here for more exact name parsing... |
Either when being directly in a git clone (eg. an osc checkout) or when sources has been transfered via a submit request. We need to be able to handle upstream source submodule here and we can not expect sources in any .osc subdirectory. Also don't stumble over a .gitmodules file when having git submodules send via submit request the sources exist already in OBS storage as obscpio, but it avoids enormous disk usage waste on git lfs server due to uncompressed data blobs there.
|
I changed it now avoiding existins tracking, but parsing instead the spec file. Checking if we have a target with a matching name in moveassets here. We could check in addition if the source also exists either as directory or directory.obspcio , but my time runs out today .... |
bugfinder
left a comment
bugfinder
left a comment
There was a problem hiding this comment.
that looks a lot better than the first approach
2 participants
Either when being directly in a git clone (eg. an osc checkout) or when sources has been transfered via a submit request.
We need to be able to handle upstream source submodule here and we can not expect sources in any .osc subdirectory.
Also don't stumble over a .gitmodules file
A more solid way would be to run the download_asset handler instead, but it would take more time and IO to do so.
when having git submodules send via submit request the sources exist already in OBS storage as obscpio, but it avoids enormous disk usage waste on git lfs server due to uncompressed data blobs there.