Skip to content

add minisign support#155

Merged
bugfinder merged 1 commit into
openSUSE:masterfrom
andreasstieger:minisign
Jan 27, 2026
Merged

add minisign support#155
bugfinder merged 1 commit into
openSUSE:masterfrom
andreasstieger:minisign

Conversation

@andreasstieger
Copy link
Copy Markdown
Member

@andreasstieger andreasstieger commented Jan 14, 2026

Adds support for verifying minisign based signatures. Keeps the pattern of the GnuPG part of the script of using .keyring files, but looks for *.minisig files.

Testing done:

  1. still validates OpenPGP signatures:
$ osc co devel:tools:building/cmake
$ cd devel:tools:building/cmake
$ osc service localrun source_validator
  1. graceful exit when installing but minisign is not installed
$ ls -1
ccache-4.12.2.tar.xz
ccache-4.12.2.tar.xz.minisig
ccache.changes
ccache.keyring
ccache.spec

$ osc service localrun source_validator
WARNING: Command 'localrun' is obsolete, please use 'run' instead.
Running source_service 'source_validator' ...
/usr/lib/obs/service/source_validators/25-keyring-validate: line 34: minisign: command not found
ERROR: signature [...]/ccache/ccache-4.12.2.tar.xz.minisig does not validate
Aborting: service call failed:  /usr/lib/obs/service/source_validator --outdir [...]/ccache/tmpa67x09de.source_validator.service
  1. validation
$ zypper in minisign
$ osc service localrun source_validator
WARNING: Command 'localrun' is obsolete, please use 'run' instead.
Running source_service 'source_validator' ...
  1. verbose, dropping -q:
Signature and comment signature verified
Trusted comment: timestamp:1764182754   file:ccache-4.12.2.tar.xz       hashed
  1. with missing minisign command:
Running source_service 'source_validator' ...
ERROR: minisign command not available
Aborting: service call failed: [...] 

@andreasstieger andreasstieger marked this pull request as draft January 19, 2026 19:10
@andreasstieger
Copy link
Copy Markdown
Member Author

Working on getting minisign into the distro first.. boo#1256939

@andreasstieger andreasstieger force-pushed the minisign branch 2 times, most recently from 34453c0 to 5df0c77 Compare January 23, 2026 22:19
@andreasstieger andreasstieger marked this pull request as ready for review January 23, 2026 22:20
Copy link
Copy Markdown
Member

@bugfinder bugfinder left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good to me

@bugfinder bugfinder merged commit 90e729c into openSUSE:master Jan 27, 2026
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants