You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
docs: document maintainer take-over of fork PRs (#1444)
* docs: document maintainer take-over of fork PRs
App installation tokens cannot push to fork branches, so maintainers
may take over a reviewed fork PR: cherry-pick to preserve authorship,
credit @username in the replacement PR description, finish remaining
nits, merge, and close the original with a link.
Pattern established in #1443 (took over #1440).
* docs: use generic placeholder instead of real username in take-over example
* docs: use noreply-email form for Co-authored-by trailer example
---------
Co-authored-by: chaodu-agent <chaodu-agent@users.noreply.github.com>
Copy file name to clipboardExpand all lines: CONTRIBUTING.md
+32Lines changed: 32 additions & 0 deletions
Display the source diff
Display the rich diff
Original file line number
Diff line number
Diff line change
@@ -279,3 +279,35 @@ Every PR follows a label-driven lifecycle that keeps the review loop moving.
279
279
-**Author comment always resets** — any comment by the PR author removes `pending-contributor` and `closing-soon`, flipping the PR back to `pending-maintainer`.
280
280
-**Re-check may re-apply `closing-soon`** — after the flip, automated checks still run. If blockers remain (e.g., missing Discord URL, CI failure, `needs-rebase`), `closing-soon` will be re-applied immediately, keeping the ball on the contributor.
281
281
-**Immediate `closing-soon`** — in some cases (e.g., missing Discord Discussion URL), `closing-soon` is applied immediately without waiting for the stale period. Auto-close follows in 24 hours.
282
+
283
+
### Maintainer Take-Over of Fork PRs
284
+
285
+
PRs from personal forks cannot always be finished on the contributor's branch:
286
+
maintainer bots authenticate with GitHub App installation tokens, which GitHub
287
+
does not allow to push to fork branches (the "Allow edits by maintainers"
288
+
mechanism only applies to user credentials). Rather than blocking a good
289
+
contribution on back-and-forth for small fixes, a maintainer may **take over**
290
+
the PR:
291
+
292
+
1.**Agree on direction first.** Take-over happens after a maintainer review,
293
+
when the approach is accepted and only nits or mechanical fixes remain —
294
+
or when the contributor is unresponsive and the change is worth landing.
295
+
2.**Preserve attribution.** Cherry-pick the contributor's commits onto a new
296
+
branch in this repository so the original commit author is preserved. If
0 commit comments