Skip to content

Commit 33610f5

Browse files
feat(chart)!: remove Helm-rendered config path, require configToml or configUrl (#1277)
BREAKING CHANGE: agents without configToml or configUrl now fail at template time with a clear error linking to docs/migrate-to-configtoml.md. - configmap.yaml: replace ~350-line TOML serializer with {{- fail}} (357 → 25 lines) - Chart.yaml: bump to 0.10.0 (breaking change in 0.x series) - NOTES.txt: remove unreachable deprecation block (fail fires before NOTES render) - docs/migrate-to-configtoml.md: update header to reflect v0.10.0 removal - tests: remove 9 suites for deleted rendering logic, update configtoml + config-url tests - Preserve: README --set-file section, ADR doc, values.yaml comments (from #1276) Co-authored-by: chaodu-agent <chaodu-agent@users.noreply.github.com>
1 parent 7dbb539 commit 33610f5

15 files changed

Lines changed: 18 additions & 1773 deletions

charts/openab/Chart.yaml

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -2,5 +2,5 @@ apiVersion: v2
22
name: openab
33
description: A lightweight, secure, cloud-native ACP harness that bridges Discord and any ACP-compatible coding CLI.
44
type: application
5-
version: 0.9.0-beta.6
6-
appVersion: "0.9.0-beta.6"
5+
version: 0.10.0
6+
appVersion: "0.10.0"

charts/openab/templates/NOTES.txt

Lines changed: 0 additions & 21 deletions
Original file line numberDiff line numberDiff line change
@@ -72,24 +72,3 @@ Agents deployed:
7272
Any env var passed via [agent].env is accessible to the agent and could be exfiltrated via prompt injection.
7373
All supported backends use OAuth/file-based auth — avoid passing API keys via env vars when possible.
7474

75-
{{- $legacyAgents := list }}
76-
{{- range $name, $cfg := .Values.agents }}
77-
{{- if ne (include "openab.agentEnabled" $cfg) "false" }}
78-
{{- if and (not $cfg.configToml) (not $cfg.configUrl) }}
79-
{{- $legacyAgents = append $legacyAgents $name }}
80-
{{- end }}
81-
{{- end }}
82-
{{- end }}
83-
{{- if $legacyAgents }}
84-
85-
⚠️ DEPRECATION NOTICE:
86-
The following agents use Helm-rendered config (slack.*, discord.*, pool.*, etc.):
87-
{{- range $legacyAgents }}
88-
• {{ . }}
89-
{{- end }}
90-
This rendering path is deprecated and will be removed in a future release.
91-
Track the removal timeline: https://github.com/openabdev/openab/issues/1278
92-
Migrate to configToml (or configUrl for a platform-agnostic setup) to write
93-
config.toml directly instead of relying on Helm's rendering.
94-
See: https://github.com/openabdev/openab/blob/main/docs/migrate-to-configtoml.md
95-
{{- end }}

charts/openab/templates/configmap.yaml

Lines changed: 1 addition & 332 deletions
Large diffs are not rendered by default.

charts/openab/tests/adapter-enablement_test.yaml

Lines changed: 0 additions & 70 deletions
This file was deleted.

charts/openab/tests/config-url_test.yaml

Lines changed: 9 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -11,8 +11,12 @@ tests:
1111
- hasDocuments:
1212
count: 0
1313

14-
- it: renders ConfigMap when configUrl is not set
14+
- it: renders ConfigMap when configUrl is not set (configToml provided)
1515
template: templates/configmap.yaml
16+
set:
17+
agents.kiro.configToml: |
18+
[agent]
19+
command = "kiro-cli"
1620
asserts:
1721
- hasDocuments:
1822
count: 1
@@ -28,6 +32,10 @@ tests:
2832

2933
- it: does not set args when configUrl is empty
3034
template: templates/deployment.yaml
35+
set:
36+
agents.kiro.configToml: |
37+
[agent]
38+
command = "kiro-cli"
3139
asserts:
3240
- isNull:
3341
path: spec.template.spec.containers[0].args

charts/openab/tests/configmap_test.yaml

Lines changed: 0 additions & 228 deletions
This file was deleted.

charts/openab/tests/configtoml-passthrough_test.yaml

Lines changed: 3 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -49,8 +49,7 @@ tests:
4949
- hasDocuments:
5050
count: 0
5151

52-
- it: falls back to Helm rendering when configToml is absent
52+
- it: fails with a clear error when neither configToml nor configUrl is set
5353
asserts:
54-
- matchRegex:
55-
path: data["config.toml"]
56-
pattern: '\[agent\]'
54+
- failedTemplate:
55+
errorPattern: "was removed in chart v0.10.0"

0 commit comments

Comments
 (0)