Skip to content

Commit be5eeaf

Browse files
author
chaodu-agent
committed
fix: address review findings for PR A
- Fix docs/antigravity.md: remove broken repository object format, use comment noting chart auto-resolves (覺渡+普渡+口渡 finding) - Add helm unit test for agentImage unified tag format (Z渡+口渡 finding): kiro default, non-kiro suffix, tag override, explicit image override
1 parent 41e2130 commit be5eeaf

2 files changed

Lines changed: 54 additions & 3 deletions

File tree

Lines changed: 53 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,53 @@
1+
suite: agentImage unified tag format
2+
templates:
3+
- templates/deployment.yaml
4+
5+
tests:
6+
- it: kiro (default) resolves to openab:<appVersion> with no agent suffix
7+
asserts:
8+
- equal:
9+
path: spec.template.spec.containers[0].image
10+
value: "ghcr.io/openabdev/openab:0.9.0-beta.1"
11+
12+
- it: non-kiro agent resolves to openab:<appVersion>-<agent>
13+
set:
14+
agents.claude.command: claude-agent-acp
15+
documentIndex: 1
16+
asserts:
17+
- equal:
18+
path: spec.template.spec.containers[0].image
19+
value: "ghcr.io/openabdev/openab:0.9.0-beta.1-claude"
20+
21+
- it: image.tag override applies to kiro
22+
set:
23+
image.tag: "beta"
24+
asserts:
25+
- equal:
26+
path: spec.template.spec.containers[0].image
27+
value: "ghcr.io/openabdev/openab:beta"
28+
29+
- it: image.tag override applies to non-kiro agent with suffix
30+
set:
31+
image.tag: "beta"
32+
agents.codex.command: codex-acp
33+
documentIndex: 1
34+
asserts:
35+
- equal:
36+
path: spec.template.spec.containers[0].image
37+
value: "ghcr.io/openabdev/openab:beta-codex"
38+
39+
- it: explicit per-agent image string with tag is used verbatim
40+
set:
41+
agents.kiro.image: "ghcr.io/custom/image:v1.0"
42+
asserts:
43+
- equal:
44+
path: spec.template.spec.containers[0].image
45+
value: "ghcr.io/custom/image:v1.0"
46+
47+
- it: explicit per-agent image string without tag gets appVersion appended
48+
set:
49+
agents.kiro.image: "ghcr.io/custom/image"
50+
asserts:
51+
- equal:
52+
path: spec.template.spec.containers[0].image
53+
value: "ghcr.io/custom/image:0.9.0-beta.1"

docs/antigravity.md

Lines changed: 1 addition & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -68,9 +68,7 @@ agents:
6868
command: "agy-acp"
6969
args: []
7070
workingDir: "/home/agent"
71-
image:
72-
repository: ghcr.io/openabdev/openab:beta-antigravity
73-
tag: "latest"
71+
# image: leave empty — chart auto-resolves to openab:<tag>-antigravity
7472
```
7573

7674
## Limitations

0 commit comments

Comments
 (0)