Skip to content

fix(ci): bundle-utils verify after symlink fix#1254

Merged
thepagent merged 1 commit into
mainfrom
fix/bundle-utils-verify
Jun 29, 2026
Merged

fix(ci): bundle-utils verify after symlink fix#1254
thepagent merged 1 commit into
mainfrom
fix/bundle-utils-verify

Conversation

@chaodu-agent

Copy link
Copy Markdown
Collaborator

The install step tried to verify ./bin/aws --version but the installer creates absolute symlinks that don't resolve in the workflow directory. Verification already happens in the 'Verify symlinks' step after fixup.

@chaodu-agent
chaodu-agent requested a review from thepagent as a code owner June 29, 2026 21:33
@chaodu-agent

This comment has been minimized.

The AWS CLI installer creates absolute symlinks in bin/ which
can't be resolved until the 'Fix symlinks' step runs. Move
verification to after symlink fixup.
@chaodu-agent
chaodu-agent force-pushed the fix/bundle-utils-verify branch from 5ab7766 to c6a3cb9 Compare June 29, 2026 21:42
@chaodu-agent

Copy link
Copy Markdown
Collaborator Author

LGTM ✅ — Removes broken pre-fixup verification and corrects the release tag prefix.

What This PR Does

The bundle-pre-seed-utils workflow ran ./bin/aws --version immediately after install, but the AWS CLI installer creates absolute symlinks that cannot resolve until the "Fix symlinks to be relative" step re-creates them as relative. Additionally, the release tag used utils-v prefix instead of the established pre-seed-utils-v convention.

How It Works

  1. Removes the broken verify line — the "Verify symlinks" step already runs ./bin/aws --version after fixup, so verification is not lost.
  2. Corrects the tag prefix — aligns with the existing release naming pattern (pre-seed-utils-v2.35.12-ghp0.3.2).

Findings

# Severity Finding Location
1 🟢 Correct removal of verify that runs before symlinks are fixed — verification already exists downstream .github/workflows/bundle-pre-seed-utils.yml:77
2 🟢 Tag prefix fix matches existing releases, prevents namespace collision .github/workflows/bundle-pre-seed-utils.yml:157
Baseline Check
  • PR branch: fix/bundle-utils-verify
  • Main has: broken ./bin/aws --version before symlink fixup + incorrect utils-v tag prefix
  • Net-new value: Fixes CI failure from broken verify + corrects tag naming to match pre-seed-utils-v* convention
  • Existing release confirms correct prefix: pre-seed-utils-v2.35.12-ghp0.3.2
What's Good (🟢)
  • Clean, minimal fix targeting exactly the two issues
  • No behavior change — verification still runs in the correct step
  • Tag rename aligns with established conventions

@thepagent
thepagent merged commit 2bc347c into main Jun 29, 2026
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants