fix(auth): reject unsupported scan authentication modes - #172
Open
dipeshbabu wants to merge 2 commits into
Open
Conversation
dipeshbabu
marked this pull request as ready for review
July 31, 2026 08:11
dipeshbabu
force-pushed
the
agent/validate-scan-auth-mode
branch
from
July 31, 2026 08:12
f7de399 to
4e46cdd
Compare
dipeshbabu
force-pushed
the
agent/validate-scan-auth-mode
branch
from
July 31, 2026 17:54
4e46cdd to
5bb0ce9
Compare
mldangelo-oai
changed the title
Collaborator
|
Codex Review: Didn't find any major issues. Breezy! Reviewed commit: ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
If Codex has suggestions, it will comment; otherwise it will react with 👍. Codex can also answer questions or update the PR. Try commenting "@codex address that feedback". |
|
Security review completed. No security issues were found in this pull request. Reviewed commit: Only the user who started this review can view the report in Codex. ℹ️ About Codex security reviews in GitHubThis is an experimental Codex feature. Security reviews are triggered when:
Once complete, Codex will leave suggestions, or a comment if no findings are found. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
auto,chatgpt, andapi-keypreflightandrunWhy
JavaScript callers can bypass the TypeScript union type. Previously, any unknown authentication string silently behaved like
auto, which could select ambient credentials instead of reporting invalid input.The shared authentication-selection boundary now raises a
TypeErrorbefore runtime initialization when the value is unsupported.Impact
Invalid SDK input fails early and predictably. Valid authentication modes are unchanged.
Validation
pnpm dlx bun test --timeout 30000 ./tests-ts/api.test.ts— 71 passedpnpm exec tsc --noEmitpnpm exec prettier --check src/api.ts tests-ts/api.test.tsgit diff --check