Skip to content

Commit 48321c1

Browse files
committed
[thread-store] clarify empty source filters
1 parent dc3dcf4 commit 48321c1

2 files changed

Lines changed: 4 additions & 2 deletions

File tree

codex-rs/app-server/src/thread_views_tests.rs

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -83,6 +83,7 @@ fn stored_thread_projection_applies_fallbacks() {
8383
reasoning_effort: None,
8484
created_at,
8585
updated_at,
86+
recency_at: updated_at,
8687
archived_at: None,
8788
cwd: cwd.clone(),
8889
cli_version: "0.0.0".to_string(),
@@ -111,6 +112,7 @@ fn stored_thread_projection_applies_fallbacks() {
111112
model_provider: "fallback-provider".to_string(),
112113
created_at: created_at.timestamp(),
113114
updated_at: updated_at.timestamp(),
115+
recency_at: Some(updated_at.timestamp()),
114116
status: ThreadStatus::NotLoaded,
115117
path: None,
116118
cwd: AbsolutePathBuf::from_absolute_path(cwd).expect("absolute path"),

codex-rs/thread-store/src/types.rs

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -185,7 +185,7 @@ pub struct ListThreadsParams {
185185
pub sort_key: ThreadSortKey,
186186
/// Sort direction requested by the caller.
187187
pub sort_direction: SortDirection,
188-
/// Allowed session sources. Empty means implementation default.
188+
/// Allowed session sources. Empty means no source filter.
189189
pub allowed_sources: Vec<SessionSource>,
190190
/// Optional model provider filter. `None` means implementation default, while an empty vector
191191
/// means all providers.
@@ -214,7 +214,7 @@ pub struct SearchThreadsParams {
214214
pub sort_key: ThreadSortKey,
215215
/// Sort direction requested by the caller.
216216
pub sort_direction: SortDirection,
217-
/// Allowed session sources. Empty means implementation default.
217+
/// Allowed session sources. Empty means no source filter.
218218
pub allowed_sources: Vec<SessionSource>,
219219
/// Whether archived threads should be searched instead of active threads.
220220
pub archived: bool,

0 commit comments

Comments
 (0)