Skip to content

Commit 7a32119

Browse files
committed
[thread-store] clarify empty source filters
1 parent 9f0273b commit 7a32119

2 files changed

Lines changed: 4 additions & 2 deletions

File tree

codex-rs/app-server/src/thread_views_tests.rs

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -83,6 +83,7 @@ fn stored_thread_projection_applies_fallbacks() {
8383
reasoning_effort: None,
8484
created_at,
8585
updated_at,
86+
recency_at: updated_at,
8687
archived_at: None,
8788
cwd: cwd.clone(),
8889
cli_version: "0.0.0".to_string(),
@@ -112,6 +113,7 @@ fn stored_thread_projection_applies_fallbacks() {
112113
model_provider: "fallback-provider".to_string(),
113114
created_at: created_at.timestamp(),
114115
updated_at: updated_at.timestamp(),
116+
recency_at: Some(updated_at.timestamp()),
115117
status: ThreadStatus::NotLoaded,
116118
path: None,
117119
cwd: AbsolutePathBuf::from_absolute_path(cwd).expect("absolute path"),

codex-rs/thread-store/src/types.rs

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -202,7 +202,7 @@ pub struct ListThreadsParams {
202202
pub sort_key: ThreadSortKey,
203203
/// Sort direction requested by the caller.
204204
pub sort_direction: SortDirection,
205-
/// Allowed session sources. Empty means implementation default.
205+
/// Allowed session sources. Empty means no source filter.
206206
pub allowed_sources: Vec<SessionSource>,
207207
/// Optional model provider filter. `None` means implementation default, while an empty vector
208208
/// means all providers.
@@ -231,7 +231,7 @@ pub struct SearchThreadsParams {
231231
pub sort_key: ThreadSortKey,
232232
/// Sort direction requested by the caller.
233233
pub sort_direction: SortDirection,
234-
/// Allowed session sources. Empty means implementation default.
234+
/// Allowed session sources. Empty means no source filter.
235235
pub allowed_sources: Vec<SessionSource>,
236236
/// Whether archived threads should be searched instead of active threads.
237237
pub archived: bool,

0 commit comments

Comments
 (0)