Skip to content

Commit cafe717

Browse files
authored
ci: migrate Bazel setup away from archived setup-bazelisk (#19851)
## Why All Bazel CI jobs are currently blocked in the `setup-bazelisk` step while trying to download Bazelisk. [`bazelbuild/setup-bazelisk`](https://github.com/bazelbuild/setup-bazelisk) is archived, and its README now recommends migrating to [`bazel-contrib/setup-bazel`](https://github.com/bazel-contrib/setup-bazel), so leaving our workflows on the archived action leaves CI exposed to exactly this sort of outage. Because `v8-canary` now consumes the shared local `setup-bazel-ci` action, that workflow also needs to trigger when the action changes. Without that follow-up, Bazel bootstrap regressions specific to the V8 canary path could be skipped by the workflow path filters. ## What Changed - Switched `.github/actions/setup-bazel-ci/action.yml` from `bazelbuild/setup-bazelisk` to `bazel-contrib/setup-bazel`, pinned to `0.19.0`. - Left `bazelisk-version` unset so GitHub-hosted runners can use their preinstalled Bazelisk instead of downloading `1.x` at job start. - Updated `.github/workflows/rusty-v8-release.yml` and `.github/workflows/v8-canary.yml` to use the shared `setup-bazel-ci` action instead of referencing `setup-bazelisk` directly. - Added `.github/actions/setup-bazel-ci/**` to the `pull_request` and `push` path filters in `.github/workflows/v8-canary.yml` so changes to the shared Bazel setup action still run the canary workflow. - Kept the existing repository-cache and Windows-specific Bazel setup logic intact. This keeps Bazel version selection anchored by `.bazelversion` while removing the failing dependency on the archived setup action. ## Verification - Searched `.github/` to confirm there are no remaining `setup-bazelisk` references. - Parsed the updated workflow and action YAML locally with Ruby's `YAML.load_file`.
1 parent c208455 commit cafe717

3 files changed

Lines changed: 9 additions & 3 deletions

File tree

.github/actions/setup-bazel-ci/action.yml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -33,7 +33,7 @@ runs:
3333
run: Copy-Item (Get-Command dotslash).Source -Destination "$env:LOCALAPPDATA\Microsoft\WindowsApps\dotslash.exe"
3434

3535
- name: Set up Bazel
36-
uses: bazelbuild/setup-bazelisk@b39c379c82683a5f25d34f0d062761f62693e0b2 # v3
36+
uses: bazel-contrib/setup-bazel@c5acdfb288317d0b5c0bbd7a396a3dc868bb0f86 # 0.19.0
3737

3838
- name: Configure Bazel repository cache
3939
id: configure_bazel_repository_cache

.github/workflows/rusty-v8-release.yml

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -78,7 +78,9 @@ jobs:
7878
- uses: actions/checkout@de0fac2e4500dabe0009e67214ff5f5447ce83dd # v6
7979

8080
- name: Set up Bazel
81-
uses: bazelbuild/setup-bazelisk@b39c379c82683a5f25d34f0d062761f62693e0b2 # v3
81+
uses: ./.github/actions/setup-bazel-ci
82+
with:
83+
target: ${{ matrix.target }}
8284

8385
- name: Set up Python
8486
uses: actions/setup-python@a309ff8b426b58ec0e2a45f0f869d46889d02405 # v6

.github/workflows/v8-canary.yml

Lines changed: 5 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -3,6 +3,7 @@ name: v8-canary
33
on:
44
pull_request:
55
paths:
6+
- ".github/actions/setup-bazel-ci/**"
67
- ".github/scripts/rusty_v8_bazel.py"
78
- ".github/workflows/rusty-v8-release.yml"
89
- ".github/workflows/v8-canary.yml"
@@ -16,6 +17,7 @@ on:
1617
branches:
1718
- main
1819
paths:
20+
- ".github/actions/setup-bazel-ci/**"
1921
- ".github/scripts/rusty_v8_bazel.py"
2022
- ".github/workflows/rusty-v8-release.yml"
2123
- ".github/workflows/v8-canary.yml"
@@ -75,7 +77,9 @@ jobs:
7577
- uses: actions/checkout@de0fac2e4500dabe0009e67214ff5f5447ce83dd # v6
7678

7779
- name: Set up Bazel
78-
uses: bazelbuild/setup-bazelisk@b39c379c82683a5f25d34f0d062761f62693e0b2 # v3
80+
uses: ./.github/actions/setup-bazel-ci
81+
with:
82+
target: ${{ matrix.target }}
7983

8084
- name: Set up Python
8185
uses: actions/setup-python@a309ff8b426b58ec0e2a45f0f869d46889d02405 # v6

0 commit comments

Comments
 (0)