Skip to content

Continue sampling after assistant chunks#19855

Draft
surajs-oai wants to merge 1 commit intomainfrom
codex_bridge/should_continue_sampling
Draft

Continue sampling after assistant chunks#19855
surajs-oai wants to merge 1 commit intomainfrom
codex_bridge/should_continue_sampling

Conversation

@surajs-oai
Copy link
Copy Markdown

Summary

  • continue sampling when a responses stream ends on reasoning or assistant commentary
  • keep the continuation decision scoped to the last completed output item

Test plan

  • just fmt
  • cargo test -p codex-core (one unrelated zsh snapshot timeout)
  • cargo test -p codex-core --lib -- --skip shell_snapshot::tests::macos_zsh_snapshot_includes_sections

When a responses stream ends on reasoning or assistant commentary, mark the sampling request for follow-up so the app server owns continuation.

Co-authored-by: Codex <noreply@openai.com>
@github-actions
Copy link
Copy Markdown
Contributor


Thank you for your submission, we really appreciate it. Like many open-source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution. You can sign the CLA by just posting a Pull Request Comment same as the below format.


I have read the CLA Document and I hereby sign the CLA


You can retrigger this bot by commenting recheck in this Pull Request. Posted by the CLA Assistant Lite bot.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant