Skip to content

Ignore legacy Windows cmd sandbox test in CI#19867

Closed
evawong-oai wants to merge 1 commit intomainfrom
codex/bugb15632-windows-cmd-test-skip
Closed

Ignore legacy Windows cmd sandbox test in CI#19867
evawong-oai wants to merge 1 commit intomainfrom
codex/bugb15632-windows-cmd-test-skip

Conversation

@evawong-oai
Copy link
Copy Markdown
Contributor

Summary

This PR skips one legacy Windows cmd.exe sandbox unit test that is currently failing only when it is forced to execute in hosted Windows CI.

The preserved path stack invalidates the windows sandbox test target through its protocol dependency, so this old test stops coming from cache and exposes CreateProcessAsUserW error 267. Adjacent legacy cmd.exe sandbox tests are already ignored for similar CI process launch instability.

Change

Adds an ignore marker to legacy_non_tty_cmd_emits_output.

Validation

  1. Rustfmt package check for codex windows sandbox passed locally.
  2. The preserved path protocol regression test is validated in the parent policy branch where that test exists.

Notes

This is split out from the preserved path policy work so reviewers can assess the CI stabilization independently.

@evawong-oai evawong-oai force-pushed the codex/bugb15632-windows-cmd-test-skip branch from 5b8dd2e to 0f697bc Compare April 27, 2026 21:14
@evawong-oai
Copy link
Copy Markdown
Contributor Author

Closing this because ignoring this test is the wrong fix. The preserved path stack no longer depends on this PR. The follow up should go to the Windows sandbox test owner.

@evawong-oai
Copy link
Copy Markdown
Contributor Author

cc @dylan-hurd-oai

I closed this skip PR because ignoring legacy_non_tty_cmd_emits_output is the wrong fix. The recent ownership trail points to #19453, which you landed to serialize the legacy Windows sandbox process tests and which calls out this same test by name. The original unified exec runtime test came from #15578 by @iceweasel-oai.

Can you take the real fix for this Windows sandbox test path? The preserved path stack has been rebased so it no longer depends on this ignore PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant