Ignore legacy Windows cmd sandbox test in CI#19867
Closed
evawong-oai wants to merge 1 commit intomainfrom
Closed
Conversation
5b8dd2e to
0f697bc
Compare
Contributor
Author
|
Closing this because ignoring this test is the wrong fix. The preserved path stack no longer depends on this PR. The follow up should go to the Windows sandbox test owner. |
Contributor
Author
|
I closed this skip PR because ignoring Can you take the real fix for this Windows sandbox test path? The preserved path stack has been rebased so it no longer depends on this ignore PR. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR skips one legacy Windows cmd.exe sandbox unit test that is currently failing only when it is forced to execute in hosted Windows CI.
The preserved path stack invalidates the windows sandbox test target through its protocol dependency, so this old test stops coming from cache and exposes CreateProcessAsUserW error 267. Adjacent legacy cmd.exe sandbox tests are already ignored for similar CI process launch instability.
Change
Adds an ignore marker to legacy_non_tty_cmd_emits_output.
Validation
Notes
This is split out from the preserved path policy work so reviewers can assess the CI stabilization independently.