Activate selected executor skills atomically#29960
Conversation
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 1531dc319e
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| for selected_root in selected_capabilities.ready() { | ||
| let selected_root_id = selected_root.selected_root().id.clone(); |
There was a problem hiding this comment.
When a selected executor root reaches Failed (for example, an unavailable environment or a non-directory selected path), this code only iterates selected_capabilities.ready() and never adds the failure message to the skill catalog. Because on_thread_start now suppresses the legacy Vec<SelectedCapabilityRoot> path whenever a selected-skill snapshot exists, the previous ExecutorSkillProvider::list warning path is bypassed, so the configured executor skills silently disappear from both prompt context and warning events instead of telling the user what failed.
Useful? React with 👍 / 👎.
| workspace = true | ||
|
|
||
| [dependencies] | ||
| codex-core-plugins = { workspace = true } |
There was a problem hiding this comment.
Adding codex-core-plugins changes the crate dependency graph, but the diff only updates Cargo.toml/Cargo.lock and leaves MODULE.bazel.lock unchanged. The repo's Bazel lock check is expected to reject dependency drift, so this change should include the output of just bazel-lock-update with the same commit.
AGENTS.md reference: AGENTS.md:L37-L39
Useful? React with 👍 / 👎.
1 participant
Summary