Skip to content

windows: contain elevated unified exec sessions#29982

Draft
anp-oai wants to merge 1 commit into
codex/pr3-03-restricted-sessionsfrom
codex/pr3-04-elevated-runner
Draft

windows: contain elevated unified exec sessions#29982
anp-oai wants to merge 1 commit into
codex/pr3-03-restricted-sessionsfrom
codex/pr3-04-elevated-runner

Conversation

@anp-oai

@anp-oai anp-oai commented Jun 25, 2026

Copy link
Copy Markdown
Collaborator

Intent

Elevated unified-exec sessions must terminate their child tree when the parent requests termination, a timeout fires, or the parent IPC transport disappears. SpawnReady must never describe an uncontained process.

Implementation

  • Remove the runner-local best-effort Job Object helper and ignored late assignment.
  • Receive an already-assigned JobProcess from both elevated pipe and ConPTY spawn paths.
  • Emit SpawnReady only after assignment and resume have succeeded.
  • Terminate the shared job on Terminate, timeout, named-pipe EOF, or control read failure.
  • Close the job before output-reader joins on normal root exit while preserving the root exit code.
  • Add elevated pipe/TTY lifecycle coverage and a real control-transport EOF test.

Manual validation

  • Built codex-windows-sandbox and codex-command-runner for Windows gnullvm with Bazel.

Stack

1. job primitives2. local ConPTY3. restricted sessions4. elevated runner5. command preparation6. raw pipe launcher7. command parity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant