windows: replace local pipe spawning#29984
Draft
anp-oai wants to merge 1 commit into
Draft
Conversation
This was referenced Jun 25, 2026
46dee87 to
d891bf2
Compare
24d6479 to
d050472
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Intent
The Windows non-TTY Tokio launch path cannot guarantee Job Object assignment before a child executes. Unified exec needs a raw launcher that preserves pipe behavior while enforcing suspended creation, assignment, and resume.
Implementation
PROC_THREAD_ATTRIBUTE_HANDLE_LIST.CreateProcessW, launch withCREATE_SUSPENDED, then assign and resume throughSuspendedProcess.SpawnedProcesschannels while preserving split stdout/stderr and tail draining.Manual validation
just test -p codex-utils-ptyon Linux.codex-utils-ptyWindows test target withcargo +1.95.0 check --target x86_64-pc-windows-msvc -p codex-utils-pty --tests.Stack
1. job primitives → 2. local ConPTY → 3. restricted sessions → 4. elevated runner → 5. command preparation → 6. raw pipe launcher → 7. command parity