Recognize Work web and mobile thread originators#29988
Conversation
|
I have read the CLA Document and I hereby sign the CLA You can retrigger this bot by commenting recheck in this Pull Request. Posted by the CLA Assistant Lite bot. |
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 35b16cc1bd
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| Some("codex_work_web"), | ||
| Some("persisted_originator"), | ||
| Some("inherited_originator"), | ||
| "codex_work_web", | ||
| ), |
There was a problem hiding this comment.
Cover serviceName remapping end to end
These new cases only call effective_originator_value directly, so they would still pass if the app-server thread/start.serviceName plumbing or the spawned thread’s outbound originator header/persisted metadata path regressed. Because this changes the agent-visible thread creation behavior for Work web/mobile, please add an integration test that starts a thread with serviceName: "codex_work_web"/"codex_work_mobile" and verifies the subsequent model request uses that originator.
AGENTS.md reference: AGENTS.md:L112-L117
Useful? React with 👍 / 👎.
Summary
codex_work_webandcodex_work_mobileas supportedthread/start.serviceNamevaluescodex_work_desktopThis is the Codex consumer for the service names introduced by openai/openai#1073178.
Rollout / Compatibility
The producer is ChatGPT's app-server integration in openai/openai#1073178. This PR is the Codex app-server consumer that converts those service names into the outgoing per-thread
originator.Until this change is deployed, the new service names are ignored and Codex continues using its fallback originator. Deploy this mapper and the matching codex-backend compatibility change in openai/openai#1073594 while the existing Flora egress overwrite remains in place. Remove that overwrite in openai/openai#1073197 only after both consumers are deployed.
Validation
just test -p codex-core effective_originator_prefers_thread_scoped_sources_before_env_originatorjust fix -p codex-corejust fmt