Skip to content

Recognize Work web and mobile thread originators#29988

Open
chiam-oai wants to merge 1 commit into
mainfrom
dev/chiam/work-web-mobile-originators
Open

Recognize Work web and mobile thread originators#29988
chiam-oai wants to merge 1 commit into
mainfrom
dev/chiam/work-web-mobile-originators

Conversation

@chiam-oai

@chiam-oai chiam-oai commented Jun 25, 2026

Copy link
Copy Markdown

Summary

  • recognize codex_work_web and codex_work_mobile as supported thread/start.serviceName values
  • use the recognized value as the thread-scoped originator, with the same persistence and request propagation added for codex_work_desktop
  • cover precedence over persisted and inherited originators

This is the Codex consumer for the service names introduced by openai/openai#1073178.

Rollout / Compatibility

The producer is ChatGPT's app-server integration in openai/openai#1073178. This PR is the Codex app-server consumer that converts those service names into the outgoing per-thread originator.

Until this change is deployed, the new service names are ignored and Codex continues using its fallback originator. Deploy this mapper and the matching codex-backend compatibility change in openai/openai#1073594 while the existing Flora egress overwrite remains in place. Remove that overwrite in openai/openai#1073197 only after both consumers are deployed.

Validation

  • just test -p codex-core effective_originator_prefers_thread_scoped_sources_before_env_originator
  • just fix -p codex-core
  • just fmt

@chiam-oai chiam-oai requested a review from a team as a code owner June 25, 2026 04:36
@github-actions

Copy link
Copy Markdown
Contributor


Thank you for your submission, we really appreciate it. Like many open-source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution. You can sign the CLA by just posting a Pull Request Comment same as the below format.


I have read the CLA Document and I hereby sign the CLA


You can retrigger this bot by commenting recheck in this Pull Request. Posted by the CLA Assistant Lite bot.

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 35b16cc1bd

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment on lines +124 to +128
Some("codex_work_web"),
Some("persisted_originator"),
Some("inherited_originator"),
"codex_work_web",
),

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P2 Badge Cover serviceName remapping end to end

These new cases only call effective_originator_value directly, so they would still pass if the app-server thread/start.serviceName plumbing or the spawned thread’s outbound originator header/persisted metadata path regressed. Because this changes the agent-visible thread creation behavior for Work web/mobile, please add an integration test that starts a thread with serviceName: "codex_work_web"/"codex_work_mobile" and verifies the subsequent model request uses that originator.

AGENTS.md reference: AGENTS.md:L112-L117

Useful? React with 👍 / 👎.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants