app-server: cover selected environments in integration tests#29992
Open
anp-oai wants to merge 5 commits into
Open
app-server: cover selected environments in integration tests#29992anp-oai wants to merge 5 commits into
anp-oai wants to merge 5 commits into
Conversation
anp-oai
commented
Jun 25, 2026
Collaborator
Author
|
@codex review |
Contributor
|
Codex Review: Didn't find any major issues. What shall we delve into next? Reviewed commit: ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
If Codex has suggestions, it will comment; otherwise it will react with 👍. Codex can also answer questions or update the PR. Try commenting "@codex address that feedback". |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
Now that basic cross-OS app/exec support is wired up, it's time to clean up the tech debt of the remote_env_windows test and make sure its test logic is covered in more maintainable feature-specific tests.
What
AGENTS.mdsources and content, plus shell and cwd context, while preserving explicit TODO baselines for the remaining host-scoped metadata.TestAppServerhelper that waits for and returns the matching typed turn completion.remote_env_windowswhile retaining its exec and apply-patch smoke coverage. A follow-up will remove these.Validation
just test -p codex-app-serverbazel test //codex-rs/app-server:app-server-all-wine-exec-test --test_output=errorsbazel test //codex-rs/core/tests/remote_env_windows:smoke-test --test_output=errors