core: pass step environments to turn input extensions#30020
Draft
sayan-oai wants to merge 1 commit into
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
Turn-input extensions currently read environments from
TurnContext, which is frozen when the turn starts. With deferred executors,run_turnmay already have a newer environment snapshot for the first sampling request.What
StepContextthrough the existing skills/plugins input builderstep_context.turnTurnInputContext.environmentsfrom the step snapshotTurnContextTurn-input contributors still run once for submitted turn input. Making their output reactive to environments that attach after the first request remains a separate WorldState/service-refresh change.
Tests
just test -p codex-core turn_input_contributors_receive_step_environmentsjust test -p codex-core 'session::turn::tests'just fix -p codex-corejust fmt