fix: preserve backward-compatible session arg ordering

Author: HuxleyHu98

examples/memory/file_session.py

@@ -47,6 +47,7 @@ async def get_session_id(self) -> str:
     async def get_items(
         self,
         limit: int | None = None,
+        *,
         wrapper: RunContextWrapper[Any] | None = None,
     ) -> list[Any]:
         session_id = await self._ensure_session_id()
@@ -58,6 +59,7 @@ async def get_items(
     async def add_items(
         self,
         items: list[Any],
+        *,
         wrapper: RunContextWrapper[Any] | None = None,
     ) -> None:
         if not items:

src/agents/extensions/memory/advanced_sqlite_session.py

@@ -140,9 +140,9 @@ async def add_items(
     async def get_items(
         self,
         limit: int | None = None,
-        wrapper: RunContextWrapper[Any] | str | None = None,
-        *,
         branch_id: str | None = None,
+        *,
+        wrapper: RunContextWrapper[Any] | None = None,
     ) -> list[TResponseInputItem]:
         """Get items from current or specified branch.
 
@@ -153,10 +153,6 @@ async def get_items(
         Returns:
             List of conversation items from the specified branch.
         """
-        if isinstance(wrapper, str) and branch_id is None:
-            branch_id = wrapper
-            wrapper = None
-
         session_limit = resolve_session_limit(limit, self.session_settings)
 
         if branch_id is None:

src/agents/memory/openai_responses_compaction_session.py

@@ -33,7 +33,6 @@ def _method_signature(method: Any) -> tuple[inspect.Parameter, ...]:
         return ()
 
 
-
 def _method_accepts_wrapper(method: Any) -> bool:
     parameters = _method_signature(method)
     return any(
@@ -42,7 +41,6 @@ def _method_accepts_wrapper(method: Any) -> bool:
     )
 
 
-
 def _method_accepts_limit(method: Any) -> bool:
     parameters = _method_signature(method)
     return any(

tests/extensions/memory/test_advanced_sqlite_wrapper_compat.py

@@ -15,14 +15,18 @@ async def test_advanced_sqlite_get_items_preserves_branch_id_positional_argument
         db_path = Path(temp_dir) / "advanced.db"
         session = AdvancedSQLiteSession(session_id="test", db_path=db_path, create_tables=True)
 
-        await session.add_items([
-            {"role": "user", "content": "main message"},
-        ])
+        await session.add_items(
+            [
+                {"role": "user", "content": "main message"},
+            ]
+        )
         branch_id = await session.create_branch_from_turn(1, "branch-a")
         assert branch_id == "branch-a"
-        await session.add_items([
-            {"role": "user", "content": "branch message"},
-        ])
+        await session.add_items(
+            [
+                {"role": "user", "content": "branch message"},
+            ]
+        )
         await session.switch_to_branch("main")
 
         branch_items = await session.get_items(50, "branch-a")