Skip to content

Commit 60a2807

Browse files
committed
refactor: make wrapper kw-only across all session implementations
Apply consistent kw-only enforcement for the wrapper parameter in get_items() and add_items() across all built-in and extension session implementations: - src/agents/memory/session.py (SessionABC + NullSession) - src/agents/memory/sqlite_session.py - src/agents/memory/openai_responses_compaction_session.py - src/agents/memory/openai_conversations_session.py - src/agents/extensions/memory/async_sqlite_session.py - src/agents/extensions/memory/advanced_sqlite_session.py - src/agents/extensions/memory/encrypt_session.py - src/agents/extensions/memory/redis_session.py - src/agents/extensions/memory/dapr_session.py - src/agents/extensions/memory/sqlalchemy_session.py - examples/memory/file_session.py
1 parent c591238 commit 60a2807

File tree

11 files changed

+297
-274
lines changed

11 files changed

+297
-274
lines changed

examples/memory/file_session.py

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -47,6 +47,7 @@ async def get_session_id(self) -> str:
4747
async def get_items(
4848
self,
4949
limit: int | None = None,
50+
*,
5051
wrapper: RunContextWrapper[Any] | None = None,
5152
) -> list[Any]:
5253
session_id = await self._ensure_session_id()
@@ -58,6 +59,7 @@ async def get_items(
5859
async def add_items(
5960
self,
6061
items: list[Any],
62+
*,
6163
wrapper: RunContextWrapper[Any] | None = None,
6264
) -> None:
6365
if not items:

src/agents/extensions/memory/advanced_sqlite_session.py

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -126,6 +126,7 @@ def _init_structure_tables(self):
126126
async def add_items(
127127
self,
128128
items: list[TResponseInputItem],
129+
*,
129130
wrapper: RunContextWrapper[Any] | None = None,
130131
) -> None:
131132
"""Add items to the session.
@@ -143,8 +144,8 @@ async def add_items(
143144
async def get_items(
144145
self,
145146
limit: int | None = None,
146-
wrapper: RunContextWrapper[Any] | None = None,
147147
*,
148+
wrapper: RunContextWrapper[Any] | None = None,
148149
branch_id: str | None = None,
149150
) -> list[TResponseInputItem]:
150151
"""Get items from current or specified branch.

src/agents/extensions/memory/async_sqlite_session.py

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -106,6 +106,7 @@ async def _locked_connection(self) -> AsyncIterator[aiosqlite.Connection]:
106106
async def get_items(
107107
self,
108108
limit: int | None = None,
109+
*,
109110
wrapper: RunContextWrapper[Any] | None = None,
110111
) -> list[TResponseInputItem]:
111112
"""Retrieve the conversation history for this session.
@@ -158,6 +159,7 @@ async def get_items(
158159
async def add_items(
159160
self,
160161
items: list[TResponseInputItem],
162+
*,
161163
wrapper: RunContextWrapper[Any] | None = None,
162164
) -> None:
163165
"""Add new items to the conversation history.

src/agents/extensions/memory/dapr_session.py

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -237,6 +237,7 @@ async def _handle_concurrency_conflict(self, error: Exception, attempt: int) ->
237237
async def get_items(
238238
self,
239239
limit: int | None = None,
240+
*,
240241
wrapper: RunContextWrapper[Any] | None = None,
241242
) -> list[TResponseInputItem]:
242243
"""Retrieve the conversation history for this session.
@@ -280,6 +281,7 @@ async def get_items(
280281
async def add_items(
281282
self,
282283
items: list[TResponseInputItem],
284+
*,
283285
wrapper: RunContextWrapper[Any] | None = None,
284286
) -> None:
285287
"""Add new items to the conversation history.

0 commit comments

Comments
 (0)