Skip to content

Commit 65e083b

Browse files
authored
Merge branch 'main' into feat/sprites-sandbox
2 parents 8008e61 + eca794c commit 65e083b

169 files changed

Lines changed: 6196 additions & 6323 deletions

File tree

Some content is hidden

Large Commits have some content hidden by default. Use the searchbox below for content that may be hidden.

.agents/skills/implementation-strategy/SKILL.md

Lines changed: 9 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -38,6 +38,15 @@ Use this skill before editing code when the task changes runtime behavior or any
3838
- If review feedback claims a change is breaking, verify it against the latest release tag and actual external impact before accepting the feedback.
3939
- If a change truly crosses the latest released contract boundary, call that out explicitly in the ExecPlan, release notes context, and user-facing summary.
4040

41+
## SDK-specific decision rules
42+
43+
- When unsupported OpenAI API or provider-adapter behavior already has a released default path, avoid turning it into a default hard error unless the latest release boundary justifies that break. Prefer an opt-in strict mode such as `strict_feature_validation=True`, while keeping the default path compatible through warning, ignoring unsupported data, or a clearly non-empty placeholder.
44+
- For OpenAI API feature gaps, evaluate streaming and non-streaming paths together. Custom tool calls, multi-choice Chat Completions chunks, non-text tool outputs, and similar provider payload differences must not be strict in one path and permissive or malformed in the other.
45+
- When a change creates new public SDK behavior, do not expose it only through hard-coded module globals. Prefer an explicit public configuration object or parameter, preserve the existing default behavior when compatibility-sensitive, and make opt-in SDK defaults explicit.
46+
- Append new optional fields or constructor parameters to public dataclasses and constructors. Do not insert them before existing public fields unless you also provide a compatibility layer and regression coverage for the old positional call shape.
47+
- Treat threshold and quota values as part of the API design when they affect runtime behavior. Distinguish OpenAI platform quota-derived values from defensive SDK defaults; if the value is not anchored in a documented platform limit, avoid making it an unconditional default-on behavior.
48+
- Define `None` semantics deliberately for public configuration. For example, use separate meanings for "feature disabled or no SDK limit", "use SDK default limits", and "disable only this specific limit" rather than relying on implicit truthiness checks.
49+
4150
## When to stop and confirm
4251

4352
- The change would alter behavior shipped in the latest release tag.

.github/codex/prompts/pr-labels.md

Lines changed: 0 additions & 73 deletions
This file was deleted.

.github/codex/prompts/release-review.md

Lines changed: 0 additions & 23 deletions
This file was deleted.

.github/codex/schemas/pr-labels.json

Lines changed: 0 additions & 29 deletions
This file was deleted.

0 commit comments

Comments
 (0)