Skip to content

Commit c591238

Browse files
committed
fix: use kw-only branch_id to satisfy seratch review and protocol compat
1 parent 0fa3217 commit c591238

2 files changed

Lines changed: 5 additions & 7 deletions

File tree

src/agents/extensions/memory/advanced_sqlite_session.py

Lines changed: 3 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -143,22 +143,20 @@ async def add_items(
143143
async def get_items(
144144
self,
145145
limit: int | None = None,
146-
wrapper: RunContextWrapper[Any] | str | None = None,
146+
wrapper: RunContextWrapper[Any] | None = None,
147+
*,
147148
branch_id: str | None = None,
148149
) -> list[TResponseInputItem]:
149150
"""Get items from current or specified branch.
150151
151152
Args:
152153
limit: Maximum number of items to return. If None, uses session_settings.limit.
154+
wrapper: Optional runtime wrapper for the current run context.
153155
branch_id: Branch to get items from. If None, uses current branch.
154156
155157
Returns:
156158
List of conversation items from the specified branch.
157159
"""
158-
if isinstance(wrapper, str) and branch_id is None:
159-
branch_id = wrapper
160-
wrapper = None
161-
162160
session_limit = resolve_session_limit(limit, self.session_settings)
163161

164162
if branch_id is None:

tests/extensions/memory/test_advanced_sqlite_wrapper_compat.py

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -10,7 +10,7 @@
1010
pytestmark = pytest.mark.asyncio
1111

1212

13-
async def test_advanced_sqlite_get_items_preserves_branch_id_positional_argument() -> None:
13+
async def test_advanced_sqlite_get_items_branch_id_kwarg() -> None:
1414
with tempfile.TemporaryDirectory() as temp_dir:
1515
db_path = Path(temp_dir) / "advanced.db"
1616
session = AdvancedSQLiteSession(session_id="test", db_path=db_path, create_tables=True)
@@ -29,7 +29,7 @@ async def test_advanced_sqlite_get_items_preserves_branch_id_positional_argument
2929
)
3030
await session.switch_to_branch("main")
3131

32-
branch_items = await session.get_items(50, "branch-a")
32+
branch_items = await session.get_items(50, branch_id="branch-a")
3333
contents = [item.get("content") for item in branch_items if isinstance(item, dict)]
3434

3535
assert "branch message" in contents

0 commit comments

Comments
 (0)