Add graceful cancel mode for streaming runs#1896
Merged
seratch merged 3 commits intoopenai:mainfrom Oct 17, 2025
Merged
Conversation
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
seratch
approved these changes
Oct 15, 2025
Member
seratch
left a comment
There was a problem hiding this comment.
LGTM @rm-openai let me know if you have any thoughts on this
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Resolves #1895
Solves the problem where canceling mid-turn discards partial work by adding an optional mode that waits for turn completion.
Implementation
API change (backward compatible):
Default is "immediate" (existing behavior). New "after_turn" mode sets a flag and lets the background task finish the current turn.
Core changes:
Checkpoints are placed after session saves, so when they trigger, the turn is already persisted.
How it works: