fix(realtime): omit null audio formats in SIP call attach updates#2454
Merged
seratch merged 1 commit intoFeb 10, 2026
Merged
Conversation
seratch
approved these changes
Feb 10, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #2308 by avoiding
format: nullinsession.updatepayloads when attaching to an existing SIP call viacall_id.In call-attach mode,
input_audio_format/output_audio_formatcan be intentionally omitted. The SDK was still serializing these as explicitnullvalues, which can cause the Realtime API to reject the update with errors like:Invalid type for 'session.audio.input.format': expected an object, but got nullWhat changed
OpenAIRealtimeWebSocketModel._get_session_config:audio.input.formatif a non-null format can be converted.audio.output.formatif a non-null format can be converted.call_idand no explicit formats, update payload omits both format fields.audio/pcmufields.Validation
uv run --with ruff ruff check src/agents/realtime/openai_realtime.py tests/realtime/test_realtime_model_settings.pyuv run --with mypy mypy src/agents/realtime/openai_realtime.py tests/realtime/test_realtime_model_settings.pyenv -u ALL_PROXY -u all_proxy -u HTTPS_PROXY -u https_proxy -u HTTP_PROXY -u http_proxy -u NO_PROXY -u no_proxy uv run --with pytest pytest -q tests/realtime/test_realtime_model_settings.pyenv -u ALL_PROXY -u all_proxy -u HTTPS_PROXY -u https_proxy -u HTTP_PROXY -u http_proxy -u NO_PROXY -u no_proxy uv run --with coverage --with pytest coverage run -m pytest -q tests/realtime/test_realtime_model_settings.pyChanged executable lines coverage (local):
src/agents/realtime/openai_realtime.py: 100% (6/6)