fix: preserve static MCP meta in converted function tools#2769
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request fixes converted MCP function tools dropping static
_metaat execution time.MCPUtil.to_function_tool()previously converted MCP tools intoFunctionToolinstances without carrying static request metadata through toinvoke_mcp_tool(). That meant MCP servers relying on_metafor request-scoped hints such as auth, locale, or session data could silently lose that information when tools were invoked through the SDK's function-tool path.This change keeps the fix narrow to the MCP conversion layer. It extracts static MCP metadata from the MCP tool object, including the current
mcp.types.ToolPydantic shape, and binds that metadata intoinvoke_mcp_tool()so the existing merge logic withtool_meta_resolverremains the single execution path.The pull request also adds regression coverage to verify that:
to_function_tool()conversion and reachesserver.call_tool(...)