fix: harden SQLAlchemySession against transient SQLite locks#2854
Merged
fix: harden SQLAlchemySession against transient SQLite locks#2854
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request fixes intermittent SQLite
database is lockedfailures inSQLAlchemySessionduring concurrent first writes in CI. It updatessrc/agents/extensions/memory/sqlalchemy_session.pyto apply SQLite connection settings that reduce lock contention and to retry transient lock errors duringadd_items()without changing the public API or schema. It also adds focused regression coverage intests/extensions/memory/test_sqlalchemy_session.pyfor transient write locks alongside the existing concurrent first-access cases.The change is a bug fix in the memory backend. The failure mode showed up as flaky CI when concurrent writers hit SQLite before or during early session initialization, so the implementation now treats short-lived SQLite lock contention as retriable instead of surfacing it immediately.