fix: #2856 stop recursive trace preview truncation#2860
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request resolves #2856. It fixes a tracing sanitization bug where JSON-compatible scalar values such as
Nonecould be replaced with preview dicts that were then recursively re-truncated under tiny byte budgets, eventually raisingRecursionErrorinside OpenAI trace payload sanitization.The change keeps the existing preview dict shape when a preview fits within the remaining budget, but treats the scalar as terminal when that preview would still be too large so the parent container can drop the child cleanly. This preserves the current behavior for normal oversized values while preventing preview-of-a-preview recursion in deeply truncated payloads.
It also adds regression coverage for the zero-budget preview path and for an oversized generation payload containing assistant messages whose
contentisNone, ensuring tracing sanitization terminates and stays within the field-size limit.