Preserve computer action modifier keys#2874
Closed
neuralatlasai wants to merge 1 commit intoopenai:mainfrom
Closed
Preserve computer action modifier keys#2874neuralatlasai wants to merge 1 commit intoopenai:mainfrom
neuralatlasai wants to merge 1 commit intoopenai:mainfrom
Conversation
Member
|
Thanks for sending this patch. Closing this in favor of #2877. The issue is real, but the compatibility boundary matters here because |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request preserves modifier keys on computer mouse actions instead of silently dropping them before driver execution.
What changed
keyssupport toComputerandAsyncComputermouse-action methodsaction.keysthrough computer action dispatch forclick,double_click,move,scroll, anddragModelBehaviorErrorwhen a modifier-bearing action reaches a legacy driver that has not implementedkeysVerification
uv sync --all-extras --all-packages --group devuv run ruff formatuv run ruff check --fixuv run ruff checkmypyon changed filespyrighton changed filespyteston impacted suites:374 passedNotes
Full repo-wide Windows verification still shows unrelated baseline issues in MCP and SQLite/tempfile cleanup paths; those are outside this patch.